Skip to content

Conversation

@aamiguet
Copy link

@aamiguet aamiguet commented Dec 7, 2025

No description provided.

@SethTisue
Copy link
Collaborator

let's merge on Tuesday, to give time for review feedback (which I've requested on Discord)

Copy link
Contributor

@merlinorg merlinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I nit-picked the word "splitted" to "split" because it's irregular and that's the standard form.

Parsing the input is quite straighforward. First let's define a type alias so that we have a meaningful type name for our value:

```scala
type Manifold = Array[Array[Char]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantically this could remain Array[String] because String supports zipWithIndex, indexOf etc, just like a collection of chars.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah... Actually I think it crossed my mind at some point, should I update it or do we leave it like that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it 😁.

Comment on lines 10 to 12
- [Solution](https://github.com/rmarbeck/advent2025/blob/main/day07/src/main/scala/Solution.scala) by [Raphaël Marbeck](https://github.com/rmarbeck)

- [Solution](https://github.com/Philippus/adventofcode/blob/main/src/main/scala/adventofcode2025/Day07.scala) by [Philippus Baalman](https://github.com/philippus)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you meant to remove these lines?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not mean to... Must have been a bad copy paste on my part. Sorry and thanks for noticing it.

I restored them.

aamiguet and others added 2 commits December 7, 2025 17:08
Co-authored-by: Merlin Hughes <merlin@merlin.org>
@aamiguet
Copy link
Author

aamiguet commented Dec 7, 2025

@merlinorg thanks for the corrections and suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants