Change method signatures to be explicitly nullable where applicable #791
+276
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarrisL2
force-pushed
the
explicit-nulls
branch
from
8cbd996 to
fd67593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes types throughout the project to be explicitly nullable where applicable. This allows downstream projects to use scala-xml without running into nullability issues if they choose to enable
-Yexplicit-nullsin their own project.However, this PR does not add the
-Yexplicit-nullsflag to build.sbt since in compiler version 3.3.x, there were less features for implicit null compatibility with Java symbols, and the project does not compile with the flag enabled. When on version 3.8.0-RC2, the project can be compiled with explicit nulls enabled.