From c77dfb6f9ce1ba635a4991e1af8f3520f0eb53f7 Mon Sep 17 00:00:00 2001 From: Steve Dignam Date: Sat, 6 Jun 2026 13:11:06 -0400 Subject: [PATCH] linter: fix github actions output clobbering json/gcc --- crates/squawk/src/config.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/crates/squawk/src/config.rs b/crates/squawk/src/config.rs index e7312bef..45dffae0 100644 --- a/crates/squawk/src/config.rs +++ b/crates/squawk/src/config.rs @@ -131,14 +131,16 @@ impl Config { info!("no error on unmatched pattern: {no_error_on_unmatched_pattern:?}"); let is_stdin = !io::stdin().is_terminal(); - let github_annotations = std::env::var("GITHUB_ACTIONS").is_ok() - && std::env::var("SQUAWK_DISABLE_GITHUB_ANNOTATIONS").is_err(); // TODO: we should support all of these in the config file as well let debug = opts.debug; let verbose = opts.verbose; let path_patterns = opts.path_patterns; let reporter = opts.reporter.unwrap_or_default(); + // Don't want to corrupt the other reporters, see issue#1186 + let github_annotations = matches!(reporter, Reporter::Tty) + && std::env::var("GITHUB_ACTIONS").is_ok() + && std::env::var("SQUAWK_DISABLE_GITHUB_ANNOTATIONS").is_err(); let stdin_filepath = opts.stdin_filepath; let upload_to_github = conf.upload_to_github; let upload_to_github_args = match opts.cmd {