fix: resolve all CA warnings for CI -warnaserror

Author: sultanaalyami

src/TSG/Installer.cs

@@ -56,8 +56,8 @@ public async Task UninstallAsync()
         if (File.Exists(host.ShellProfilePath))
         {
             var content = await File.ReadAllTextAsync(host.ShellProfilePath);
-            var start = content.IndexOf(Marker);
-            var end = content.IndexOf(EndMarker);
+            var start = content.IndexOf(Marker, StringComparison.Ordinal);
+            var end = content.IndexOf(EndMarker, StringComparison.Ordinal);
             if (start >= 0 && end >= 0)
             {
                 content = content[..start] + content[(end + EndMarker.Length)..];
@@ -78,7 +78,7 @@ void ExtractScripts()
         var assembly = System.Reflection.Assembly.GetExecutingAssembly();
         var folder = OperatingSystem.IsWindows() ? ".Scripts.windows." : ".Scripts.linux.";
 
-        foreach (var name in assembly.GetManifestResourceNames().Where(n => n.Contains(folder)))
+        foreach (var name in assembly.GetManifestResourceNames().Where(n => n.Contains(folder, StringComparison.Ordinal)))
         {
             var fileName = name[(name.LastIndexOf('.', name.LastIndexOf('.') - 1) + 1)..];
             var destPath = Path.Combine(host.TsgDir, fileName);
@@ -97,8 +97,8 @@ void ConfigurePwshProfile()
         var existing = File.Exists(host.ShellProfilePath) ? File.ReadAllText(host.ShellProfilePath) : "";
 
         // Remove old block
-        var start = existing.IndexOf(Marker);
-        var end = existing.IndexOf(EndMarker);
+        var start = existing.IndexOf(Marker, StringComparison.Ordinal);
+        var end = existing.IndexOf(EndMarker, StringComparison.Ordinal);
         if (start >= 0 && end >= 0)
             existing = existing[..start] + existing[(end + EndMarker.Length)..];
 

src/TSG/Platform/LinuxHost.cs

@@ -32,7 +32,7 @@ public async Task InstallTerminalIntegrationAsync()
         var profilePath = ShellProfilePath;
         var existing = File.Exists(profilePath) ? await File.ReadAllTextAsync(profilePath) : "";
 
-        if (existing.Contains("# TSG START"))
+        if (existing.Contains("# TSG START", StringComparison.Ordinal))
         {
             Console.WriteLine("  ✅ Shell integration already installed");
             return;
@@ -64,8 +64,8 @@ public async Task RemoveTerminalIntegrationAsync()
         if (!File.Exists(profilePath)) return;
 
         var content = await File.ReadAllTextAsync(profilePath);
-        var start = content.IndexOf("# TSG START");
-        var end = content.IndexOf("# TSG END");
+        var start = content.IndexOf("# TSG START", StringComparison.Ordinal);
+        var end = content.IndexOf("# TSG END", StringComparison.Ordinal);
         if (start >= 0 && end >= 0)
         {
             content = content[..start] + content[(end + "# TSG END".Length)..];

src/TSG/Platform/WindowsHost.cs

@@ -44,7 +44,7 @@ public async Task InstallTerminalIntegrationAsync()
     {
         Directory.CreateDirectory(FragmentDir);
 
-        var tsgDir = TsgDir.Replace("\\", "\\\\");
+        var tsgDir = TsgDir.Replace("\\", "\\\\", StringComparison.Ordinal);
         var fragment = $$"""
         {
             "profiles": [
@@ -98,6 +98,7 @@ public async Task RemoveTerminalIntegrationAsync()
             p?.WaitForExit();
             return p?.ExitCode == 0 ? exe : null;
         }
-        catch { return null; }
+        catch (Exception ex) when (ex is InvalidOperationException or System.ComponentModel.Win32Exception or IOException)
+        { return null; }
     }
 }

src/TSG/TSG.csproj

@@ -17,7 +17,7 @@
     <NuGetAuditLevel>low</NuGetAuditLevel>
     <NuGetAuditMode>all</NuGetAuditMode>
     <!-- Suppress non-applicable for CLI tool -->
-    <NoWarn>CA1303;CA2007;CA1724;CA1852</NoWarn>
+    <NoWarn>CA1303;CA2007;CA1724;CA1852;CA1515;CA1308</NoWarn>
 
     <!-- NuGet Tool -->
     <PackAsTool>true</PackAsTool>