Fixed the CI smoke test script and verified your kill/restart flow passes end-to-end.

Rewrote demo/postgres-survive-kill9/ci-smoke.sh to:
Wait for Postgres readiness and pgbench tables before taking the baseline.
Explicitly docker compose up -d postgres after SIGKILL, then wait for readiness and tables again.
Keep the metric check and teardown.
Marked the script executable.
Ran ./ci-smoke.sh locally: it completed successfully (baseline captured, kill, restart, count preserved, metrics scraped) and brought the stack down afterward.

Author: Shane Wall

demo/postgres-survive-kill9/ci-smoke.sh

@@ -9,51 +9,47 @@ cleanup() {
 }
 trap cleanup EXIT
 
-docker compose up -d
-
-echo "Waiting for Postgres to be ready..."
-ready=0
-for i in {1..30}; do
-  if docker compose exec -T postgres pg_isready -U postgres >/dev/null 2>&1; then
-    ready=1
-    break
+wait_pg() {
+  echo "Waiting for Postgres to be ready..."
+  local ready=0
+  for _ in {1..30}; do
+    if docker compose exec -T postgres pg_isready -U postgres >/dev/null 2>&1; then
+      ready=1
+      break
+    fi
+    sleep 2
+  done
+  if [[ "$ready" != "1" ]]; then
+    echo "Postgres did not become ready in time" >&2
+    exit 1
   fi
-  sleep 2
-done
-if [[ "${ready}" != "1" ]]; then
-  echo "Postgres did not become ready in time" >&2
+}
+
+wait_pgbench_tables() {
+  echo "Waiting for pgbench tables..."
+  for _ in {1..30}; do
+    if docker compose exec -T postgres psql -U postgres -d bench -t -A -c "SELECT 1 FROM pg_tables WHERE tablename='pgbench_history';" 2>/dev/null | grep -q 1; then
+      return
+    fi
+    sleep 2
+  done
+  echo "pgbench tables did not appear in time" >&2
   exit 1
-fi
+}
 
-# Wait for pgbench tables to exist (loader may still be initializing)
-echo "Waiting for pgbench tables..."
-for i in {1..30}; do
-  if docker compose exec -T postgres psql -U postgres -d bench -t -A -c "SELECT 1 FROM pg_tables WHERE tablename='pgbench_history';" 2>/dev/null | grep -q 1; then
-    break
-  fi
-  sleep 2
-done
+docker compose up -d
+wait_pg
+wait_pgbench_tables
 
 baseline=$(docker compose exec -T postgres psql -U postgres -d bench -t -A -c "SELECT count(*) FROM pgbench_history;" 2>/dev/null || echo "0")
 echo "Baseline transactions: ${baseline}"
 
 docker kill -s KILL "$(docker compose ps -q postgres)"
 
 echo "Waiting for Postgres to restart..."
-# Explicitly restart to avoid edge cases where manual SIGKILL bypasses restart policy
 docker compose up -d postgres >/dev/null 2>&1
-ready=0
-for i in {1..30}; do
-  sleep 2
-  if docker compose exec -T postgres pg_isready -U postgres >/dev/null 2>&1; then
-    ready=1
-    break
-  fi
-done
-if [[ "${ready}" != "1" ]]; then
-  echo "Postgres did not restart" >&2
-  exit 1
-fi
+wait_pg
+wait_pgbench_tables
 
 after=$(docker compose exec -T postgres psql -U postgres -d bench -t -A -c "SELECT count(*) FROM pgbench_history;" 2>/dev/null || echo "0")
 echo "Post-restart transactions: ${after}"
@@ -63,4 +59,4 @@ if (( after < baseline )); then
 fi
 
 curl -sf http://localhost:9911/metrics | grep diffkeeper_recovery_total
-echo "CI smoke test: PASS"
+echo "CI smoke test: PASS"