Skip to content

Commit cd4a41c

Browse files
bnoordhuisaddaleax
authored andcommitted
src: remove node::InitializeV8Platform()
This API method was introduced in commit 90ae4bd ("src: add InitializeV8Platform function") from July 2018 but wasn't properly exported and therefore not usable on Windows or with shared library builds. The motivation from the commit log is mainly about making it easier to wire up the cctests and there are better ways to do that. Refs: nodejs#31217 PR-URL: nodejs#31245 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 93b0e39 commit cd4a41c

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

src/api/environment.cc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -360,11 +360,6 @@ MultiIsolatePlatform* CreatePlatform(
360360
return new NodePlatform(thread_pool_size, tracing_controller);
361361
}
362362

363-
MultiIsolatePlatform* InitializeV8Platform(int thread_pool_size) {
364-
per_process::v8_platform.Initialize(thread_pool_size);
365-
return per_process::v8_platform.Platform();
366-
}
367-
368363
void FreePlatform(MultiIsolatePlatform* platform) {
369364
delete platform;
370365
}

src/node.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,6 @@ NODE_EXTERN MultiIsolatePlatform* GetMainThreadMultiIsolatePlatform();
401401
NODE_EXTERN MultiIsolatePlatform* CreatePlatform(
402402
int thread_pool_size,
403403
node::tracing::TracingController* tracing_controller);
404-
MultiIsolatePlatform* InitializeV8Platform(int thread_pool_size);
405404
NODE_EXTERN void FreePlatform(MultiIsolatePlatform* platform);
406405

407406
NODE_EXTERN void EmitBeforeExit(Environment* env);

0 commit comments

Comments
 (0)