Comments in authorized_keys are truncated in ssh_auth module

[Whissi]

Description of Issue/Question

The ssh_auth state module truncates comments on first space.

Setup

$ cat /srv/salt/demo/truncated-comment.sls:

thatch:
  ssh_auth.present:
    - user: root
    - source: salt://ssh_keys/thatch.id_rsa.pub

$ cat /srv/salt/ssh_keys/thatch.id_rsa.pub:

ssh-rsa AAAAB3NzaC1yc2EAAAABJQAAAQEAp1J43RvhempWiclhhKmtEUySbEgMFbFLwGnefy//dHkij+yKEf2i52OdPSQNw2PwZJJEuofZYCppmiDRZ1zsrzRC7ly8IFdElaz99YeYpYWXw4oj6dZQK4NYBuhVv4cdHyCE349nXWkVm836rKaDaBTEzBiP/aLegqp2QeO4UgC6J7SjNVm0wp3WkWoRDTvdrbD9W94mO6XjJoD3J27pQ2bsDt83dQzmh1MDTGuv5cUxwMPww8YMXJcv7c5HUW3F+/ZTjpom2DJZRDc4p5rpOipEhEA0G+qPmmka86AQtiNywYek4P8dvTukkjV47AZZIopnbp2tt9n3Le9TnXjiXw== Thomas Hatch

Expected result

cat /root/.ssh/authorized_keys
ssh-rsa AAAAB3NzaC1yc2EAAAABJQAAAQEAp1J43RvhempWiclhhKmtEUySbEgMFbFLwGnefy//dHkij+yKEf2i52OdPSQNw2PwZJJEuofZYCppmiDRZ1zsrzRC7ly8IFdElaz99YeYpYWXw4oj6dZQK4NYBuhVv4cdHyCE349nXWkVm836rKaDaBTEzBiP/aLegqp2QeO4UgC6J7SjNVm0wp3WkWoRDTvdrbD9W94mO6XjJoD3J27pQ2bsDt83dQzmh1MDTGuv5cUxwMPww8YMXJcv7c5HUW3F+/ZTjpom2DJZRDc4p5rpOipEhEA0G+qPmmka86AQtiNywYek4P8dvTukkjV47AZZIopnbp2tt9n3Le9TnXjiXw== Thomas Hatch

Actual result

cat /root/.ssh/authorized_keys
ssh-rsa AAAAB3NzaC1yc2EAAAABJQAAAQEAp1J43RvhempWiclhhKmtEUySbEgMFbFLwGnefy//dHkij+yKEf2i52OdPSQNw2PwZJJEuofZYCppmiDRZ1zsrzRC7ly8IFdElaz99YeYpYWXw4oj6dZQK4NYBuhVv4cdHyCE349nXWkVm836rKaDaBTEzBiP/aLegqp2QeO4UgC6J7SjNVm0wp3WkWoRDTvdrbD9W94mO6XjJoD3J27pQ2bsDt83dQzmh1MDTGuv5cUxwMPww8YMXJcv7c5HUW3F+/ZTjpom2DJZRDc4p5rpOipEhEA0G+qPmmka86AQtiNywYek4P8dvTukkjV47AZZIopnbp2tt9n3Le9TnXjiXw== Thomas

(" Hatch" is missing).

Versions Report

Salt Version:
           Salt: 2016.11.1

Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: 2.5.3
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.8
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.4.8
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
         pygit2: Not Installed
         Python: 2.7.13 (default, Jan 19 2017, 14:48:08)
   python-gnupg: Not Installed
         PyYAML: 3.12
          PyZMQ: 16.0.2
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.4.2
            ZMQ: 4.2.1

System Versions:
           dist: debian 9.0
        machine: x86_64
        release: 4.9.0-2-amd64
         system: Linux
        version: debian 9.0

[Ch3LL]

is that even allowed?

From the sshd man page:

Protocol 1 public keys con‐sist of the following space-separated fields: options, bits, exponent, modulus, comment.

I read that as the comment should not be space-separated. I could be completely wrong here though.

[Whissi]

Well, at least for SSH_KNOWN_HOSTS file (which is similar), the sshd man page says

Each line in these files contains the following fields: markers (optional), hostnames, keytype, base64-encoded key, comment. The fields are separated by spaces.

[...]

The keytype and base64-encoded key are taken directly from the host key; they can be obtained, for example, from /etc/ssh/ssh_host_rsa_key.pub. The optional comment field continues to the end of the line, and is not used.

And popular tools like puttygen set multi word comments.

[Ch3LL]

Well I just learned something new today. Thanks for detailing that. I am able to replicate your issue so we will need to get this fixed up. Thanks!