Skip to content

refactor(tetris, space-invaders): migrate to Cougr ECS as core archit…#139

Closed
victor62-art wants to merge 3 commits into
salazarsebas:mainfrom
victor62-art:refactor/tetris-space-invaders-cougr-ecs
Closed

refactor(tetris, space-invaders): migrate to Cougr ECS as core archit…#139
victor62-art wants to merge 3 commits into
salazarsebas:mainfrom
victor62-art:refactor/tetris-space-invaders-cougr-ecs

Conversation

@victor62-art
Copy link
Copy Markdown

…ecture

  • Replace decorative/transitional ECS usage with real SimpleWorld ownership
  • Add components.rs and systems.rs to both examples
  • Remove game_state.rs from space_invaders (replaced by components + systems)
  • All game entities now live in SimpleWorld; systems query/mutate via ComponentTrait
  • GameState/GameMeta structs hold only non-entity metadata (score, level, etc.)
  • Remove all legacy, transitional, and old-version comments
  • Update README architecture sections for both examples
  • All existing tests pass: tetris 7/7, space_invaders 13/13

closes #137

…ecture

- Replace decorative/transitional ECS usage with real SimpleWorld ownership
- Add components.rs and systems.rs to both examples
- Remove game_state.rs from space_invaders (replaced by components + systems)
- All game entities now live in SimpleWorld; systems query/mutate via ComponentTrait
- GameState/GameMeta structs hold only non-entity metadata (score, level, etc.)
- Remove all legacy, transitional, and old-version comments
- Update README architecture sections for both examples
- All existing tests pass: tetris 7/7, space_invaders 13/13
@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Apr 23, 2026

@victor62-art Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@salazarsebas
Copy link
Copy Markdown
Owner

Hey @victor62-art , please fix the workflow errors

@salazarsebas
Copy link
Copy Markdown
Owner

Hey @victor62-art , what are the updates on this pull request?

Reminder: The abandoned pr will be closed and the issue will be reassigned.

@victor62-art
Copy link
Copy Markdown
Author

@salazarsebas yh i'll fix it now

@victor62-art
Copy link
Copy Markdown
Author

@salazarsebas sorry for taking this long but i'm done

@salazarsebas
Copy link
Copy Markdown
Owner

Hey @victor62-art , the workflows keep failing because you haven't run the cargo fmt command

@victor62-art
Copy link
Copy Markdown
Author

@salazarsebas i've done that but it's not the issue

@salazarsebas
Copy link
Copy Markdown
Owner

@salazarsebas i've done that but it's not the issue

According to the workflow logs, it says that the fmt fails

@salazarsebas
Copy link
Copy Markdown
Owner

The PR is closed because there were no updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify Cougr integration in tetris and space invaders

3 participants