remove workaround for fixed-in-2017 Safari bug, especially because it triggered deprecated react warnings

Author: williamstein

src/packages/frontend/editor.coffee

@@ -1375,13 +1375,6 @@ class CodeMirrorEditor extends FileEditor
             # Save for next time
             @_last_layout = @_layout
 
-        # Workaround a major and annoying bug in Safari:
-        #     https://github.com/philipwalton/flexbugs/issues/132
-        if $.browser.safari and @_layout == 1
-            # This is only needed for the "split via a horizontal line" layout, since
-            # the flex layout with column direction is broken on Safari.
-            @element.find(".webapp-editor-codemirror-input-container-layout-#{@_layout}").make_height_defined()
-
         refresh = (cm) =>
             return if not cm?
             cm_refresh(cm)

src/packages/frontend/frame-editors/code-editor/codemirror-editor.tsx

@@ -215,20 +215,12 @@ export const CodemirrorEditor: React.FC<Props> = React.memo((props) => {
     editor_actions()?.syncstring_commit();
   }
 
-  function safari_hack(): void {
-    if (is_safari()) {
-      $(ReactDOM.findDOMNode(divRef.current)).make_height_defined();
-    }
-  }
-
   async function init_codemirror(props: Props): Promise<void> {
     const node: HTMLTextAreaElement = ReactDOM.findDOMNode(textareaRef.current);
     if (node == null) {
       return;
     }
 
-    safari_hack();
-
     const options: any = cm_options(
       props.path,
       props.editor_settings,
@@ -309,7 +301,7 @@ export const CodemirrorEditor: React.FC<Props> = React.memo((props) => {
     (cm as any)._actions = editor_actions();
 
     if (props.is_public) {
-      if (props.value !== undefined) {
+      if (props.value != null) {
         // should always be the case if public.
         cm.setValue(props.value);
       }
@@ -514,8 +506,6 @@ export const CodemirrorEditor: React.FC<Props> = React.memo((props) => {
   );
 });
 
-CodemirrorEditor.defaultProps = { value: "" };
-
 // Needed e.g., for vim ":w" support; this is global,
 // so be careful.
 if ((CodeMirror as any).commands.save == null) {

src/packages/frontend/frame-editors/frame-tree/frame-tree-drag-bar.tsx

@@ -58,11 +58,10 @@ interface Props {
   // the direction
   dir: "col" | "row";
   frame_tree: Map<string, any>;
-  safari_hack: () => void;
 }
 
 export const FrameTreeDragBar: React.FC<Props> = React.memo((props: Props) => {
-  const { dir, frame_tree, actions, safari_hack, containerRef } = props;
+  const { dir, frame_tree, actions, containerRef } = props;
 
   const dragBarRef = React.useRef<Draggable>(null);
 
@@ -104,7 +103,6 @@ export const FrameTreeDragBar: React.FC<Props> = React.memo((props: Props) => {
     setDragActive(false);
     drag_stop_iframe_enable();
     calcPosition(_, ui);
-    safari_hack();
   }
 
   function style(): CSS | undefined {

src/packages/frontend/frame-editors/frame-tree/frame-tree.tsx

@@ -461,7 +461,6 @@ export const FrameTree: React.FC<FrameTreeProps> = React.memo(
             containerRef={cols_container_ref}
             dir={"col"}
             frame_tree={frame_tree}
-            safari_hack={safari_hack}
           />
           <div className={"smc-vfill"} style={data.style_second}>
             {render_one(data.second)}
@@ -470,17 +469,6 @@ export const FrameTree: React.FC<FrameTreeProps> = React.memo(
       );
     }
 
-    function safari_hack() {
-      if (!is_safari()) {
-        return;
-      }
-      // Workaround a major and annoying bug in Safari:
-      //     https://github.com/philipwalton/flexbugs/issues/132
-      return $(ReactDOM.findDOMNode(elementRef.current))
-        .find(".cocalc-editor-div")
-        .make_height_defined();
-    }
-
     function render_rows() {
       const data = get_data("column");
       return (
@@ -497,7 +485,6 @@ export const FrameTree: React.FC<FrameTreeProps> = React.memo(
             containerRef={rows_container_ref}
             dir={"row"}
             frame_tree={frame_tree}
-            safari_hack={safari_hack}
           />
           <div className={"smc-vfill"} style={data.style_second}>
             {render_one(data.second)}

src/packages/frontend/frame-editors/generic/jquery-plugins.ts

@@ -6,7 +6,5 @@
 import "jquery";
 
 declare global {
-  interface JQuery {
-    make_height_defined(): JQuery;
-  }
+  interface JQuery {}
 }

src/packages/frontend/frame-editors/html-editor/iframe-html.tsx

@@ -85,7 +85,6 @@ export const IFrameHTML: React.FC<Props> = React.memo((props: Props) => {
   React.useEffect(function () {
     mounted.current = true;
     reload_iframe();
-    safari_hack();
     set_iframe_style(scaling);
     return function () {
       mounted.current = false;
@@ -206,12 +205,6 @@ export const IFrameHTML: React.FC<Props> = React.memo((props: Props) => {
     }
   }
 
-  function safari_hack(): void {
-    if (is_safari()) {
-      $(ReactDOM.findDOMNode(rootEl.current)).make_height_defined();
-    }
-  }
-
   function render_no_html(): Rendered {
     return (
       <div>

src/packages/frontend/jquery-plugins/height.ts

@@ -16,14 +16,3 @@ $.fn.maxheight = function (opts: { offset?: number } = {}) {
   });
   return this;
 };
-
-// Use to workaround Safari flex layout bug https://github.com/philipwalton/flexbugs/issues/132
-$.fn.make_height_defined = function () {
-  this.each(function () {
-    // @ts-ignore
-    const elt = $(this);
-    // Doing this makes the height **defined**, so that flexbox can use it even on safari.
-    elt.height(elt.height());
-  });
-  return this;
-};