Merge pull request #25 from ryancyq/test/blob

test: more coverage for blob

Author: ryancyq

__tests__/blob.test.ts

@@ -2,7 +2,7 @@ import * as core from '@actions/core'
 import fs from 'node:fs'
 import { join } from 'node:path'
 import { Buffer } from 'node:buffer'
-import { Readable } from 'node:stream'
+import { Readable, PassThrough } from 'node:stream'
 import { describe, jest, beforeEach, it, expect } from '@jest/globals'
 import { Blob, getBlob } from '../src/blob'
 import * as cwd from '../src/utils/cwd'
@@ -25,32 +25,76 @@ describe('Blob', () => {
     expect(blob.absolutePath).toBe(join(__dirname, '/my_path.txt'))
   })
 
-  it('stream', async () => {
-    const blob = new Blob('/my_stream.txt')
-    jest
-      .spyOn(blob, 'streamable', 'get')
-      .mockReturnValue(Readable.from('Hello World'))
-
-    const chunks: Buffer[] = []
-    for await (const chunk of blob.streamable) {
-      chunks.push(Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk))
-    }
-    const streamedContent = Buffer.concat(chunks).toString('utf8')
-    expect(streamedContent).toEqual('Hello World')
-  })
-
   it('getBlob', async () => {
     const blob = getBlob('fixtures/blob.json')
 
     expect(blob.path).toBe('fixtures/blob.json')
     expect(blob.absolutePath).toBe(join(__dirname, 'fixtures/blob.json'))
   })
 
-  it('load', async () => {
-    const blob = getBlob('fixtures/blob.txt')
-    const fileAddition = await blob.load()
-    expect(fileAddition.contents).toEqual(
-      fs.readFileSync(join(__dirname, 'fixtures/blob.base64.txt')).toString()
-    )
+  it('getBlob collection', async () => {
+    const blobs = getBlob(['fixtures/blob.json'])
+    expect(blobs.length).toBe(1)
+    const blob = blobs[0]
+    expect(blob.path).toBe('fixtures/blob.json')
+    expect(blob.absolutePath).toBe(join(__dirname, 'fixtures/blob.json'))
+  })
+
+  describe('stream', () => {
+    it('file does not exist', async () => {
+      const blob = new Blob('/my_stream.txt')
+      expect(() => blob.streamable).toThrow(
+        /^File does not exist, path: .+\/my_stream\.txt$/
+      )
+    })
+
+    it('file exists', async () => {
+      const blob = new Blob('/my_stream.txt')
+      jest
+        .spyOn(blob, 'streamable', 'get')
+        .mockReturnValue(Readable.from('Hello World'))
+
+      const chunks: Buffer[] = []
+      for await (const chunk of blob.streamable) {
+        chunks.push(Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk))
+      }
+      const streamedContent = Buffer.concat(chunks).toString('utf8')
+      expect(streamedContent).toEqual('Hello World')
+    })
+  })
+
+  describe('load', () => {
+    it('successfully', async () => {
+      const blob = getBlob('fixtures/blob.txt')
+      const fileAddition = await blob.load()
+      expect(fileAddition.contents).toEqual(
+        fs.readFileSync(join(__dirname, 'fixtures/blob.base64.txt')).toString()
+      )
+    })
+
+    it('file with string', async () => {
+      const blob = getBlob('fixtures/error.txt')
+      const mockStream = new PassThrough()
+      jest.spyOn(blob, 'streamable', 'get').mockReturnValue(mockStream)
+
+      const loadPromise = blob.load()
+      mockStream.emit('data', 'string data')
+      mockStream.end()
+      await expect(loadPromise).resolves.toEqual({
+        contents: 'string data',
+        path: 'fixtures/error.txt',
+      })
+    })
+
+    it('stream with error', async () => {
+      const blob = getBlob('fixtures/error.txt')
+      const mockStream = new PassThrough()
+      jest.spyOn(blob, 'streamable', 'get').mockReturnValue(mockStream)
+
+      blob.load()
+      expect(() => mockStream.emit('error', new Error('stream error'))).toThrow(
+        /^Read file failed, error: stream error, path: .+\/fixtures\/error\.txt$/
+      )
+    })
   })
 })

dist/index.js

@@ -30375,7 +30375,7 @@ class Blob {
     }
     get streamable() {
         if (!fs.existsSync(this.absolutePath)) {
-            throw new Error(`File does not exist, path: ${this.absolutePath}.`);
+            throw new Error(`File does not exist, path: ${this.absolutePath}`);
         }
         return fs
             .createReadStream(this.absolutePath, { encoding: 'utf8' })

src/blob.ts

@@ -23,7 +23,7 @@ export class Blob {
 
   get streamable(): Readable {
     if (!fs.existsSync(this.absolutePath)) {
-      throw new Error(`File does not exist, path: ${this.absolutePath}.`)
+      throw new Error(`File does not exist, path: ${this.absolutePath}`)
     }
 
     return fs