File tree Expand file tree Collapse file tree 1 file changed +1
-15
lines changed
Expand file tree Collapse file tree 1 file changed +1
-15
lines changed Original file line number Diff line number Diff line change @@ -63,19 +63,13 @@ macro_rules! impl_least_squares {
6363 a_layout. lda( ) ,
6464 b,
6565 // this is the 'leading dimension of b', in the case where
66- // b is a single vector, this should be 1
66+ // b is a single vector, this is 1
6767 nrhs,
6868 & mut singular_values,
6969 rcond,
7070 & mut rank,
7171 ) ;
7272
73- // FIXME: make use of this fact (from lapack docs)
74- // https://www.netlib.org/lapack/explore-html/d7/d3b/group__double_g_esolve_ga94bd4a63a6dacf523e25ff617719f752
75- // could check how this is done by scipy here: https://github.com/scipy/scipy/blob/v1.4.1/scipy/linalg/basic.py#L1047-L1246
76- // If m >= n and RANK = n, the residual
77- // sum-of-squares for the solution in the i-th column is given
78- // by the sum of squares of elements n+1:m in that column.
7973 into_result(
8074 status,
8175 LeastSquaresOutput {
@@ -114,20 +108,12 @@ macro_rules! impl_least_squares {
114108 a,
115109 a_layout. lda( ) ,
116110 b,
117- // this is the 'leading dimension of b', in the case where
118- // b is a single vector, this should be 1
119111 b_layout. lda( ) ,
120112 & mut singular_values,
121113 rcond,
122114 & mut rank,
123115 ) ;
124116
125- // FIXME: make use of this fact (from lapack docs)
126- // https://www.netlib.org/lapack/explore-html/d7/d3b/group__double_g_esolve_ga94bd4a63a6dacf523e25ff617719f752
127- // could check how this is done by scipy here: https://github.com/scipy/scipy/blob/v1.4.1/scipy/linalg/basic.py#L1047-L1246
128- // If m >= n and RANK = n, the residual
129- // sum-of-squares for the solution in the i-th column is given
130- // by the sum of squares of elements n+1:m in that column.
131117 into_result(
132118 status,
133119 LeastSquaresOutput {
You can’t perform that action at this time.
0 commit comments