-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Open
Labels
C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCS-tracking-unimplementedStatus: The feature has not been implemented.Status: The feature has not been implemented.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.
Description
Feature gate: #![feature(try_as_dyn)]
This is a tracking issue for the try_as_dyn and try_as_dyn_mut functions.
This feature will let us try to turn any value into a dyn MyTrait. If the value does not implement MyTrait then we simply return None so that the user can have some default functionality happen instead.
We expect to be able to remove many cases of specialization from the compiler and instead perform this kind of downcasting in the bodies of functions that were relying on specialization before.
A simple example could be
// Look ma, no `T: Debug`
fn downcast_debug_format<T: 'static>(t: &T) -> String {
match std::any::try_as_dyn::<_, dyn Debug>(t) {
Some(d) => format!("{d:?}"),
None => "default".to_string()
}
}Public API
pub const fn try_as_dyn<
T: Any + 'static,
U: ptr::Pointee<Metadata = ptr::DynMetadata<U>> + ?Sized + 'static,
>(
t: &T,
) -> Option<&U>
pub const fn try_as_dyn_mut<
T: Any + 'static,
U: ptr::Pointee<Metadata = ptr::DynMetadata<U>> + ?Sized + 'static,
>(
t: &mut T,
) -> Option<&mut U>Steps / History
(Remember to update the S-tracking-* label when checking boxes.)
- Implementation: Add try_as_dyn and try_as_dyn_mut #150033
- Remove 'static requirement (see https://rust-lang.zulipchat.com/#narrow/channel/144729-t-types/topic/solver.20mode.20for.20downcast_trait/with/560560270)
- Final comment period (FCP)1
- Stabilization PR
Unresolved Questions
- Where should these functions live?
Currently the implementations are in theanymodule, which can be very confusing as thesedowncastconcepts are for statically known types, while thedowncastconcepts inAnyproper are for dynamic runtime types. - try_as_dyn can observe whether a type hidden behind a RPIT implements a trait or not. This makes the opaque/hiding part of opaque types useless. This is hard to avoid because const eval generally reveals opaque types to get layout information
Footnotes
danielhenrymantilla, tim-blackbird, Scripter17, jakobhellermann, dimpolo and 8 moredanielhenrymantilla, cramertj, tim-blackbird, Scripter17, jasper310899 and 3 more
Metadata
Metadata
Assignees
Labels
C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCS-tracking-unimplementedStatus: The feature has not been implemented.Status: The feature has not been implemented.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.