Skip to content

Commit fafd6de

Browse files
committed
genmc/api: Remove unnecessary comments
These comments explain the default values used internally in (some) calls of the GenMC library, which is unnecessary.
1 parent d2176c3 commit fafd6de

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

src/tools/miri/genmc-sys/cpp/src/MiriInterface/Exploration.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,6 @@ void MiriGenmcShim::handle_thread_create(ThreadId thread_id, ThreadId parent_id)
461461
const ThreadInfo child_info =
462462
ThreadInfo { thread_id, parent_id, fun_id, arg, "unknown thread" };
463463

464-
// NOTE: Default memory ordering (`Release`) used here.
465464
const auto child_tid = GenMCDriver::handleThreadCreate(nullptr, pos, child_info, EventDeps());
466465
// Sanity check the thread id, which is the index in the `threads_action_` array.
467466
BUG_ON(child_tid != thread_id || child_tid <= 0 || child_tid != threads_action_.size());
@@ -472,7 +471,6 @@ void MiriGenmcShim::handle_thread_join(ThreadId thread_id, ThreadId child_id) {
472471
// The thread join event happens in the parent.
473472
const auto pos = inc_pos(thread_id);
474473

475-
// NOTE: Default memory ordering (`Acquire`) used here.
476474
const auto ret = GenMCDriver::handleThreadJoin(nullptr, pos, child_id, EventDeps());
477475
// If the join failed, decrease the event index again:
478476
if (!std::holds_alternative<SVal>(ret)) {
@@ -485,7 +483,6 @@ void MiriGenmcShim::handle_thread_join(ThreadId thread_id, ThreadId child_id) {
485483

486484
void MiriGenmcShim::handle_thread_finish(ThreadId thread_id, uint64_t ret_val) {
487485
const auto pos = inc_pos(thread_id);
488-
// NOTE: Default memory ordering (`Release`) used here.
489486
GenMCDriver::handleThreadFinish(nullptr, pos, SVal(ret_val));
490487
}
491488

0 commit comments

Comments
 (0)