Rollup merge of #94714 - ChrisDenton:win-close_read_wakes_up, r=Mark-Simulacrum

Dylan-DPC · web-flow · commit ee8109d12d0c · 2022-03-08T22:43:57.000+01:00
Enable `close_read_wakes_up` test on Windows I wonder if we could/should try enabling this again? It was closed by #38867 due to #31657. I've tried running this test (along with other tests) on my machine a number of times and haven't seen this fail yet, Caveat: the worst that can happen is this succeeds initially but then causes random hangs in CI. This is not a great failure mode and would be a reason not to do this. If this does work out, closes #39006 r? `@Mark-Simulacrum`
diff --git a/library/std/src/net/tcp/tests.rs b/library/std/src/net/tcp/tests.rs
@@ -508,7 +508,6 @@ fn close_readwrite_smoke() {
 }
 
 #[test]
-#[cfg(unix)] // test doesn't work on Windows, see #31657
 fn close_read_wakes_up() {
     each_ip(&mut |addr| {
         let a = t!(TcpListener::bind(&addr));

Original file line number	Diff line number	Diff line change
`@@ -508,7 +508,6 @@ fn close_readwrite_smoke() {`
`508`	`508`	`}`
`509`	`509`
`510`	`510`	`#[test]`
`511`		`-#[cfg(unix)] // test doesn't work on Windows, see #31657`
`512`	`511`	`fn close_read_wakes_up() {`
`513`	`512`	`each_ip(&mut \|addr\| {`
`514`	`513`	`let a = t!(TcpListener::bind(&addr));`