Add feature to set path-based visibility of macro_rules to pub by default

Author: yaahc

compiler/rustc_lint/src/builtin.rs

@@ -1247,6 +1247,7 @@ impl UnreachablePub {
         let mut applicability = Applicability::MachineApplicable;
         if cx.tcx.visibility(def_id).is_public() && !cx.effective_visibilities.is_reachable(def_id)
         {
+
             // prefer suggesting `pub(super)` instead of `pub(crate)` when possible,
             // except when `pub(super) == pub(crate)`
             let new_vis = if let Some(ty::Visibility::Restricted(restricted_did)) =
@@ -1288,6 +1289,12 @@ impl<'tcx> LateLintPass<'tcx> for UnreachablePub {
         if let hir::ItemKind::Use(_, hir::UseKind::ListStem) = &item.kind {
             return;
         }
+        // Do not warn for macro_rules definitions which are pub and unreachable by default,
+        // only check their associated use re-exports.
+        if let hir::ItemKind::Macro(_, _,_) = &item.kind {
+            // TODO: How do I differentiate between `macro` and `macro_rules!` definitions?
+            return;
+        }
         self.perform_lint(cx, "item", item.owner_id.def_id, item.vis_span, true);
     }
 

compiler/rustc_resolve/src/build_reduced_graph.rs

@@ -1299,11 +1299,7 @@ impl<'a, 'ra, 'tcx> BuildReducedGraphVisitor<'a, 'ra, 'tcx> {
             let ident = ident.normalize_to_macros_2_0();
             self.r.macro_names.insert(ident);
             let is_macro_export = ast::attr::contains_name(&item.attrs, sym::macro_export);
-            let vis = if is_macro_export {
-                Visibility::Public
-            } else {
-                Visibility::Restricted(CRATE_DEF_ID)
-            };
+            let vis = Visibility::Public;
             let binding = self.r.arenas.new_res_binding(res, vis.to_def_id(), span, expansion);
             self.r.set_binding_parent_module(binding, parent_scope.module);
             self.r.all_macro_rules.insert(ident.name);