fix method receiver lint test cases

Author: chenyukang

library/core/src/num/f128.rs

@@ -1323,7 +1323,7 @@ impl f128 {
     /// assert!((-3.0f128).clamp(-2.0, 1.0) == -2.0);
     /// assert!((0.0f128).clamp(-2.0, 1.0) == 0.0);
     /// assert!((2.0f128).clamp(-2.0, 1.0) == 1.0);
-    /// assert!((f128::NAN).clamp(-2.0, 1.0).is_nan());
+    /// assert!(f128::NAN.clamp(-2.0, 1.0).is_nan());
     ///
     /// // These always returns zero, but the sign (which is ignored by `==`) is non-deterministic.
     /// assert!((0.0f128).clamp(-0.0, -0.0) == 0.0);

library/core/src/num/f16.rs

@@ -1307,7 +1307,7 @@ impl f16 {
     /// assert!((-3.0f16).clamp(-2.0, 1.0) == -2.0);
     /// assert!((0.0f16).clamp(-2.0, 1.0) == 0.0);
     /// assert!((2.0f16).clamp(-2.0, 1.0) == 1.0);
-    /// assert!((f16::NAN).clamp(-2.0, 1.0).is_nan());
+    /// assert!(f16::NAN.clamp(-2.0, 1.0).is_nan());
     ///
     /// // These always returns zero, but the sign (which is ignored by `==`) is non-deterministic.
     /// assert!((0.0f16).clamp(-0.0, -0.0) == 0.0);

library/core/src/num/f32.rs

@@ -1489,7 +1489,7 @@ impl f32 {
     /// assert!((-3.0f32).clamp(-2.0, 1.0) == -2.0);
     /// assert!((0.0f32).clamp(-2.0, 1.0) == 0.0);
     /// assert!((2.0f32).clamp(-2.0, 1.0) == 1.0);
-    /// assert!((f32::NAN).clamp(-2.0, 1.0).is_nan());
+    /// assert!(f32::NAN.clamp(-2.0, 1.0).is_nan());
     ///
     /// // These always returns zero, but the sign (which is ignored by `==`) is non-deterministic.
     /// assert!((0.0f32).clamp(-0.0, -0.0) == 0.0);

library/core/src/num/f64.rs

@@ -1487,7 +1487,7 @@ impl f64 {
     /// assert!((-3.0f64).clamp(-2.0, 1.0) == -2.0);
     /// assert!((0.0f64).clamp(-2.0, 1.0) == 0.0);
     /// assert!((2.0f64).clamp(-2.0, 1.0) == 1.0);
-    /// assert!((f64::NAN).clamp(-2.0, 1.0).is_nan());
+    /// assert!(f64::NAN.clamp(-2.0, 1.0).is_nan());
     ///
     /// // These always returns zero, but the sign (which is ignored by `==`) is non-deterministic.
     /// assert!((0.0f64).clamp(-0.0, -0.0) == 0.0);

library/core/src/num/int_macros.rs

@@ -2570,7 +2570,7 @@ macro_rules! int_impl {
         ///
         /// ```
         #[doc = concat!("assert_eq!(1", stringify!($SelfT), ".overflowing_add_unsigned(2), (3, false));")]
-        #[doc = concat!("assert_eq!((", stringify!($SelfT), "::MIN).overflowing_add_unsigned(", stringify!($UnsignedT), "::MAX), (", stringify!($SelfT), "::MAX, false));")]
+        #[doc = concat!("assert_eq!(", stringify!($SelfT), "::MIN.overflowing_add_unsigned(", stringify!($UnsignedT), "::MAX), (", stringify!($SelfT), "::MAX, false));")]
         #[doc = concat!("assert_eq!((", stringify!($SelfT), "::MAX - 2).overflowing_add_unsigned(3), (", stringify!($SelfT), "::MIN, true));")]
         /// ```
         #[stable(feature = "mixed_integer_ops", since = "1.66.0")]
@@ -2677,7 +2677,7 @@ macro_rules! int_impl {
         ///
         /// ```
         #[doc = concat!("assert_eq!(1", stringify!($SelfT), ".overflowing_sub_unsigned(2), (-1, false));")]
-        #[doc = concat!("assert_eq!((", stringify!($SelfT), "::MAX).overflowing_sub_unsigned(", stringify!($UnsignedT), "::MAX), (", stringify!($SelfT), "::MIN, false));")]
+        #[doc = concat!("assert_eq!(", stringify!($SelfT), "::MAX.overflowing_sub_unsigned(", stringify!($UnsignedT), "::MAX), (", stringify!($SelfT), "::MIN, false));")]
         #[doc = concat!("assert_eq!((", stringify!($SelfT), "::MIN + 2).overflowing_sub_unsigned(3), (", stringify!($SelfT), "::MAX, true));")]
         /// ```
         #[stable(feature = "mixed_integer_ops", since = "1.66.0")]
@@ -3010,7 +3010,7 @@ macro_rules! int_impl {
         /// ```
         #[doc = concat!("assert_eq!(10", stringify!($SelfT), ".overflowing_abs(), (10, false));")]
         #[doc = concat!("assert_eq!((-10", stringify!($SelfT), ").overflowing_abs(), (10, false));")]
-        #[doc = concat!("assert_eq!((", stringify!($SelfT), "::MIN).overflowing_abs(), (", stringify!($SelfT), "::MIN, true));")]
+        #[doc = concat!("assert_eq!(", stringify!($SelfT), "::MIN.overflowing_abs(), (", stringify!($SelfT), "::MIN, true));")]
         /// ```
         #[stable(feature = "no_panic_abs", since = "1.13.0")]
         #[rustc_const_stable(feature = "const_int_methods", since = "1.32.0")]

library/core/src/num/uint_macros.rs

@@ -1125,7 +1125,7 @@ macro_rules! uint_impl {
         /// ```
         ///
         /// ```should_panic
-        #[doc = concat!("let _ = (", stringify!($SelfT), "::MAX).strict_sub_signed(-1);")]
+        #[doc = concat!("let _ = ", stringify!($SelfT), "::MAX.strict_sub_signed(-1);")]
         /// ```
         #[stable(feature = "strict_overflow_ops", since = "1.91.0")]
         #[rustc_const_stable(feature = "strict_overflow_ops", since = "1.91.0")]
@@ -2433,7 +2433,7 @@ macro_rules! uint_impl {
         ///
         /// ```
         #[doc = concat!("assert_eq!(2", stringify!($SelfT), ".saturating_mul(10), 20);")]
-        #[doc = concat!("assert_eq!((", stringify!($SelfT), "::MAX).saturating_mul(10), ", stringify!($SelfT),"::MAX);")]
+        #[doc = concat!("assert_eq!(", stringify!($SelfT), "::MAX.saturating_mul(10), ", stringify!($SelfT),"::MAX);")]
         /// ```
         #[stable(feature = "wrapping", since = "1.7.0")]
         #[rustc_const_stable(feature = "const_saturating_int_methods", since = "1.47.0")]

tests/ui/lint/unused-parens-method-receiver-issue-151985.fixed

@@ -13,14 +13,17 @@ fn main() {
     x.method(); //~ ERROR unnecessary parentheses around method receiver
 
     // Necessary parens - should NOT warn
-    let _ = (1..10).sum::<i32>();           // Range expression
-    let _ = (1_i32 + 2).abs();               // Binary expression
-    let _ = (-1_i32).abs();                  // Unary expression
-    let _ = (true as i32).abs();             // Cast expression
-    let _ = (&42).clone();                   // AddrOf expression
-    let _ = (&mut 42).clone();               // AddrOf mut expression
+    let _ = (1..10).sum::<i32>(); // Range expression
+    let _ = (1_i32 + 2).abs(); // Binary expression
+    let _ = (-1_i32).abs(); // Unary expression
+    let _ = (true as i32).abs(); // Cast expression
+    let _ = (&42).clone(); // AddrOf expression
+    let _ = (&mut 42).clone(); // AddrOf mut expression
 
     // Block expressions - should NOT warn
-    let _ = ({ 1_i32 }).abs();               // Block expression
+    let _ = ({ 1_i32 }).abs(); // Block expression
     let _ = (unsafe { std::mem::zeroed::<i32>() }).abs(); // Unsafe block expression
+
+    // lint for path with multiple segments
+    let _ = std::cmp::Ordering::Equal.is_eq(); //~ ERROR unnecessary parentheses around method receiver
 }

tests/ui/lint/unused-parens-method-receiver-issue-151985.rs

@@ -25,5 +25,5 @@ fn main() {
     let _ = (unsafe { std::mem::zeroed::<i32>() }).abs(); // Unsafe block expression
 
     // lint for path with multiple segments
-    let _ = (Float::MIN_POSITIVE).midpoint(-Float::MAX);
+    let _ = (std::cmp::Ordering::Equal).is_eq(); //~ ERROR unnecessary parentheses around method receiver
 }

tests/ui/lint/unused-parens-method-receiver-issue-151985.stderr

@@ -15,5 +15,17 @@ LL -     (x).method();
 LL +     x.method();
    |
 
-error: aborting due to 1 previous error
+error: unnecessary parentheses around method receiver
+  --> $DIR/unused-parens-method-receiver-issue-151985.rs:28:13
+   |
+LL |     let _ = (std::cmp::Ordering::Equal).is_eq();
+   |             ^                         ^
+   |
+help: remove these parentheses
+   |
+LL -     let _ = (std::cmp::Ordering::Equal).is_eq();
+LL +     let _ = std::cmp::Ordering::Equal.is_eq();
+   |
+
+error: aborting due to 2 previous errors