wip: ui tests for attribute parsing

Author: nebulark

compiler/rustc_codegen_ssa/src/codegen_attrs.rs

@@ -1,5 +1,6 @@
 use rustc_ast::{ast, attr, MetaItemKind, NestedMetaItem};
 use rustc_attr::{list_contains_name, InlineAttr, InstructionSetAttr, OptimizeAttr};
+use rustc_data_structures::packed::Pu128;
 use rustc_errors::{codes::*, struct_span_code_err};
 use rustc_hir as hir;
 use rustc_hir::def::DefKind;
@@ -489,7 +490,7 @@ fn codegen_fn_attrs(tcx: TyCtxt<'_>, did: LocalDefId) -> CodegenFnAttrs {
                                 tcx.dcx().span_err(
                                     item.span(),
                                     format!(
-                                        "Unexpected name. Allowed names: {}, {}",
+                                        "Unexpected parameter name. Allowed names: {}, {}",
                                         sym::prefix_nops,
                                         sym::entry_nops
                                     ),
@@ -498,23 +499,16 @@ fn codegen_fn_attrs(tcx: TyCtxt<'_>, did: LocalDefId) -> CodegenFnAttrs {
                             }
                         };
 
-                        let rustc_ast::LitKind::Int(val, _) = name_value_lit.kind else {
+                        let rustc_ast::LitKind::Int(Pu128(val @ 0..=255), _) = name_value_lit.kind
+                        else {
                             tcx.dcx().span_err(
                                 name_value_lit.span,
                                 "Expected integer value between 0 and 255.",
                             );
                             continue;
                         };
 
-                        let Ok(val) = val.get().try_into() else {
-                            tcx.dcx().span_err(
-                                name_value_lit.span,
-                                "Integer value outside range between 0 and 255.",
-                            );
-                            continue;
-                        };
-
-                        *attrib_to_write = Some(val);
+                        *attrib_to_write = Some(val.try_into().unwrap());
                     }
 
                     if let (None, None) = (prefix, entry) {

tests/ui/patchable-function-entry/patchable-function-entry-attribute.rs

@@ -0,0 +1,17 @@
+#![feature(patchable_function_entry)]
+fn main() {}
+
+#[patchable_function_entry(prefix_nops = 256, entry_nops = 0)]
+pub fn too_high_pnops() {}
+
+#[patchable_function_entry(prefix_nops = "stringvalue", entry_nops = 0)]
+pub fn non_int_nop() {}
+
+#[patchable_function_entry]
+pub fn malformed_attribute() {}
+
+#[patchable_function_entry(prefix_nops = 10, something = 0)]
+pub fn unexpected_parameter_name() {}
+
+#[patchable_function_entry()]
+pub fn no_parameters_given() {}

tests/ui/patchable-function-entry/patchable-function-entry-attribute.stderr

@@ -0,0 +1,32 @@
+error: malformed `patchable_function_entry` attribute input
+  --> $DIR/patchable-function-entry-attribute.rs:10:1
+   |
+LL | #[patchable_function_entry]
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: must be of the form: `#[patchable_function_entry(prefix_nops = m, entry_nops = n)]`
+
+error: Expected integer value between 0 and 255.
+  --> $DIR/patchable-function-entry-attribute.rs:4:42
+   |
+LL | #[patchable_function_entry(prefix_nops = 256, entry_nops = 0)]
+   |                                          ^^^
+
+error: Expected integer value between 0 and 255.
+  --> $DIR/patchable-function-entry-attribute.rs:7:42
+   |
+LL | #[patchable_function_entry(prefix_nops = "stringvalue", entry_nops = 0)]
+   |                                          ^^^^^^^^^^^^^
+
+error: Unexpected parameter name. Allowed names: prefix_nops, entry_nops
+  --> $DIR/patchable-function-entry-attribute.rs:13:46
+   |
+LL | #[patchable_function_entry(prefix_nops = 10, something = 0)]
+   |                                              ^^^^^^^^^^^^^
+
+error: Must specify at least one parameter.
+  --> $DIR/patchable-function-entry-attribute.rs:16:1
+   |
+LL | #[patchable_function_entry()]
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+error: aborting due to 5 previous errors
+