apply review feedback nits

- correct indentation
- rename `from_cause` to `from_obligation_cause`
- break up `compare_impl_method` into fns
- delete some blank lines and correct comment

Author: nikomatsakis

src/librustc/infer/mod.rs

@@ -1172,7 +1172,9 @@ impl<'a, 'gcx, 'tcx> InferCtxt<'a, 'gcx, 'tcx> {
         self.commit_if_ok(|snapshot| {
             let (ty::OutlivesPredicate(r_a, r_b), skol_map) =
                 self.skolemize_late_bound_regions(predicate, snapshot);
-            let origin = SubregionOrigin::from_cause(cause, || RelateRegionParamBound(cause.span));
+            let origin =
+                SubregionOrigin::from_obligation_cause(cause,
+                                                       || RelateRegionParamBound(cause.span));
             self.sub_regions(origin, r_b, r_a); // `b : a` ==> `a <= b`
             self.leak_check(false, cause.span, &skol_map, snapshot)?;
             Ok(self.pop_skolemized(skol_map, snapshot))
@@ -1809,9 +1811,9 @@ impl<'tcx> SubregionOrigin<'tcx> {
         }
     }
 
-    pub fn from_cause<F>(cause: &traits::ObligationCause<'tcx>,
-                         default: F)
-                         -> Self
+    pub fn from_obligation_cause<F>(cause: &traits::ObligationCause<'tcx>,
+                                    default: F)
+                                    -> Self
         where F: FnOnce() -> Self
     {
         match cause.code {

src/librustc/traits/util.rs

@@ -1,4 +1,3 @@
-
 // Copyright 2014 The Rust Project Developers. See the COPYRIGHT
 // file at the top-level directory of this distribution and at
 // http://rust-lang.org/COPYRIGHT.
@@ -185,7 +184,7 @@ impl<'cx, 'gcx, 'tcx> Elaborator<'cx, 'gcx, 'tcx> {
                 // `'a: 'b`.
 
                 // Ignore `for<'a> T: 'a` -- we might in the future
-                // consider this as evidence that `Foo: 'static`, but
+                // consider this as evidence that `T: 'static`, but
                 // I'm a bit wary of such constructions and so for now
                 // I want to be conservative. --nmatsakis
                 let ty_max = data.skip_binder().0;