Remove #[derive(Show)]

Author: petrochenkov

src/doc/style/features/traits/common.md

@@ -9,18 +9,18 @@ applicable, common traits.
 
 To see why, consider the following situation:
 
-* Crate `std` defines trait `Show`.
-* Crate `url` defines type `Url`, without implementing `Show`.
+* Crate `std` defines trait `Debug`.
+* Crate `url` defines type `Url`, without implementing `Debug`.
 * Crate `webapp` imports from both `std` and `url`,
 
-There is no way for `webapp` to add `Show` to `url`, since it defines neither.
+There is no way for `webapp` to add `Debug` to `url`, since it defines neither.
 (Note: the newtype pattern can provide an efficient, but inconvenient
 workaround; see [newtype for views](../types/newtype.md))
 
 The most important common traits to implement from `std` are:
 
 ```rust
-Clone, Show, Hash, Eq
+Clone, Debug, Hash, Eq
 ```
 
 #### When safe, derive or otherwise implement `Send` and `Share`. [FIXME]

src/etc/generate-deriving-span-tests.py

@@ -119,7 +119,7 @@ def write_file(name, string):
                               ('PartialOrd', ['PartialEq'], 8),
                               ('Eq', ['PartialEq'], 1),
                               ('Ord', ['Eq', 'PartialOrd', 'PartialEq'], 1),
-                              ('Show', [], 1),
+                              ('Debug', [], 1),
                               ('Hash', [], 1)]:
     traits[trait] = (ALL, supers, errs)
 

src/libsyntax/ext/deriving/show.rs src/libsyntax/ext/deriving/debug.rssrc/libsyntax/ext/deriving/show.rs renamed to src/libsyntax/ext/deriving/debug.rs

@@ -18,7 +18,7 @@ use ext::deriving::generic::ty::*;
 use parse::token;
 use ptr::P;
 
-pub fn expand_deriving_show(cx: &mut ExtCtxt,
+pub fn expand_deriving_debug(cx: &mut ExtCtxt,
                             span: Span,
                             mitem: &MetaItem,
                             item: &Annotatable,

src/libsyntax/ext/deriving/mod.rs

@@ -60,7 +60,7 @@ pub mod clone;
 pub mod encodable;
 pub mod decodable;
 pub mod hash;
-pub mod show;
+pub mod debug;
 pub mod default;
 pub mod primitive;
 
@@ -173,7 +173,7 @@ derive_traits! {
     "PartialOrd" => partial_ord::expand_deriving_partial_ord,
     "Ord" => ord::expand_deriving_ord,
 
-    "Debug" => show::expand_deriving_show,
+    "Debug" => debug::expand_deriving_debug,
 
     "Default" => default::expand_deriving_default,
 
@@ -184,15 +184,13 @@ derive_traits! {
     "Copy" => bounds::expand_deriving_copy,
 
     // deprecated
-    "Show" => show::expand_deriving_show,
     "Encodable" => encodable::expand_deriving_encodable,
     "Decodable" => decodable::expand_deriving_decodable,
 }
 
 #[inline] // because `name` is a compile-time constant
 fn warn_if_deprecated(ecx: &mut ExtCtxt, sp: Span, name: &str) {
     if let Some(replacement) = match name {
-        "Show" => Some("Debug"),
         "Encodable" => Some("RustcEncodable"),
         "Decodable" => Some("RustcDecodable"),
         _ => None,

src/test/run-pass/arr_cycle.rs

@@ -10,7 +10,7 @@
 
 use std::cell::Cell;
 
-#[derive(Show)]
+#[derive(Debug)]
 struct B<'a> {
     a: [Cell<Option<&'a B<'a>>>; 2]
 }

src/test/run-pass/const-adt-align-mismatch.rs

@@ -10,7 +10,7 @@
 
 use std::mem;
 
-#[derive(PartialEq, Show)]
+#[derive(PartialEq, Debug)]
 enum Foo {
     A(u32),
     Bar([u16; 4]),

src/test/run-pass/deprecated-derive.rs

@@ -8,8 +8,12 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-#[derive(Show)]
-//~^ WARNING derive(Show) is deprecated
+#![feature(rustc_private)]
+
+extern crate serialize;
+
+#[derive(Encodable)]
+//~^ WARNING derive(Encodable) is deprecated in favor of derive(RustcEncodable)
 struct Test1;
 
 fn main() { }

src/test/run-pass/vec_cycle.rs

@@ -10,7 +10,7 @@
 
 use std::cell::Cell;
 
-#[derive(Show)]
+#[derive(Debug)]
 struct C<'a> {
     v: Vec<Cell<Option<&'a C<'a>>>>,
 }

src/test/run-pass/vec_cycle_wrapped.rs

@@ -10,12 +10,12 @@
 
 use std::cell::Cell;
 
-#[derive(Show)]
+#[derive(Debug)]
 struct Refs<'a> {
     v: Vec<Cell<Option<&'a C<'a>>>>,
 }
 
-#[derive(Show)]
+#[derive(Debug)]
 struct C<'a> {
     refs: Refs<'a>,
 }