fixes after running cargo test and update lints

Author: yonip23

CHANGELOG.md

@@ -3278,7 +3278,7 @@ Released 2018-09-13
 [`allow_attributes_without_reason`]: https://rust-lang.github.io/rust-clippy/master/index.html#allow_attributes_without_reason
 [`almost_swapped`]: https://rust-lang.github.io/rust-clippy/master/index.html#almost_swapped
 [`approx_constant`]: https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
-[`arc_in_vec_init`]: https://rust-lang.github.io/rust-clippy/master/index.html#arc_in_vec_init
+[`arc_new_in_vec_from_slice`]: https://rust-lang.github.io/rust-clippy/master/index.html#arc_new_in_vec_from_slice
 [`as_conversions`]: https://rust-lang.github.io/rust-clippy/master/index.html#as_conversions
 [`assertions_on_constants`]: https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants
 [`assign_op_pattern`]: https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern

clippy_lints/src/arc_new_in_vec_from_slice.rs

@@ -1,7 +1,7 @@
 use clippy_utils::diagnostics::span_lint_and_help;
 use clippy_utils::macros::{root_macro_call_first_node, MacroCall};
 use clippy_utils::{last_path_segment, match_def_path, paths};
-use rustc_hir::*;
+use rustc_hir::{Expr, ExprKind, QPath, TyKind};
 use rustc_lint::{LateContext, LateLintPass};
 use rustc_session::{declare_lint_pass, declare_tool_lint};
 use rustc_span::sym;
@@ -40,7 +40,7 @@ impl LateLintPass<'_> for ArcNewInVecFromSlice {
 
         if_chain! {
             if let ExprKind::Call(func, args) = expr.peel_drop_temps().kind;
-            if let ExprKind::Path(QPath::Resolved(_ty, ref path)) = func.kind;
+            if let ExprKind::Path(QPath::Resolved(_ty, path)) = func.kind;
             if let Some(did) = path.res.opt_def_id();
             then {
                 if !(match_def_path(cx, did, &paths::VEC_FROM_ELEM) && first_arg_is_arc_new(args)) { return; }

tests/ui/arc_new_in_vec_from_slice/complex_case.stderr

@@ -1,13 +1,15 @@
 error: calling `Arc::new` in `vec![elem; len]`
   --> $DIR/complex_case.rs:5:13
    |
-LL |       let v = vec![std::sync::Arc::new(Mutex::new({
+LL |       let v = vec![
    |  _____________^
-LL | |         let x = 1;
-LL | |         dbg!(x);
-LL | |         x
-LL | |     })); 2];
-   | |___________^
+LL | |         std::sync::Arc::new(Mutex::new({
+LL | |             let x = 1;
+LL | |             dbg!(x);
+...  |
+LL | |         2
+LL | |     ];
+   | |_____^
    |
    = note: `-D clippy::arc-new-in-vec-from-slice` implied by `-D warnings`
    = help: consider extracting `Arc` initialization to a variable