fix review comments

Author: yonip23

clippy_lints/src/ref_clone_in_vec_init.rs

@@ -20,14 +20,20 @@ declare_clippy_lint! {
     /// ```rust
     /// let v = vec![std::sync::Arc::new("some data".to_string()); 100];
     /// // or
-    /// let v = vec![std::rc::Rc::new("some data".to_string())];
+    /// let v = vec![std::rc::Rc::new("some data".to_string()); 100];
     /// ```
     /// Use instead:
     /// ```rust
-    /// let data = std::sync::Arc::new("some data".to_string());
-    /// // or
+    /// // Create the reference beforehand to clarify it that
+    /// // this reference should be cloned for each value
     /// let data = std::rc::Rc::new("some data".to_string());
     /// let v = vec![data; 100];
+    ///
+    /// // Or initialize each value separately:
+    /// let mut data = Vec::with_capacity(100);
+    /// for _ in 0..=100 {
+    ///     data.push(std::rc::Rc::new("some data".to_string()));
+    /// }
     /// ```
     #[clippy::version = "1.62.0"]
     pub REF_CLONE_IN_VEC_INIT,
@@ -42,11 +48,11 @@ impl LateLintPass<'_> for RefCloneInVecInit {
         let Some(VecArgs::Repeat(elem, _)) = VecArgs::hir(cx, expr) else { return; };
         let Some(symbol) = new_reference_call(cx, elem) else { return; };
 
-        yield_lint(cx, symbol, &macro_call);
+        emit_lint(cx, symbol, &macro_call);
     }
 }
 
-fn yield_lint(cx: &LateContext<'_>, symbol: Symbol, macro_call: &MacroCall) {
+fn emit_lint(cx: &LateContext<'_>, symbol: Symbol, macro_call: &MacroCall) {
     let symbol_name = symbol.as_str();
 
     span_lint_and_then(
@@ -55,10 +61,11 @@ fn yield_lint(cx: &LateContext<'_>, symbol: Symbol, macro_call: &MacroCall) {
         macro_call.span,
         &format!("calling `{symbol_name}::new` in `vec![elem; len]`"),
         |diag| {
-            diag.note(format!("each `{symbol_name}` will point to the same allocation"));
-            diag.help(format!(
-                "if this is intentional, consider extracting the `{symbol_name}` initialization to a variable"
-            ));
+            diag.note(format!("each element will point to the same `{symbol_name}` instance"))
+                .help(format!(
+                    "if this is intentional, consider extracting the `{symbol_name}` initialization to a variable"
+                ))
+                .help("or if not, initilaize each element individually");
         },
     );
 }

tests/ui/ref_clone_in_vec_init/arc/complex_case.stderr

@@ -12,8 +12,9 @@ LL | |     ];
    | |_____^
    |
    = note: `-D clippy::ref-clone-in-vec-init` implied by `-D warnings`
-   = note: each `Arc` will point to the same allocation
+   = note: each element will point to the same `Arc` instance
    = help: if this is intentional, consider extracting the `Arc` initialization to a variable
+   = help: or if not, initilaize each element individually
 
 error: aborting due to previous error
 

tests/ui/ref_clone_in_vec_init/arc/simple_case.stderr

@@ -5,8 +5,9 @@ LL |     let v = vec![Arc::new("x".to_string()); 2];
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D clippy::ref-clone-in-vec-init` implied by `-D warnings`
-   = note: each `Arc` will point to the same allocation
+   = note: each element will point to the same `Arc` instance
    = help: if this is intentional, consider extracting the `Arc` initialization to a variable
+   = help: or if not, initilaize each element individually
 
 error: aborting due to previous error
 

tests/ui/ref_clone_in_vec_init/rc/complex_case.stderr

@@ -12,8 +12,9 @@ LL | |     ];
    | |_____^
    |
    = note: `-D clippy::ref-clone-in-vec-init` implied by `-D warnings`
-   = note: each `Rc` will point to the same allocation
+   = note: each element will point to the same `Rc` instance
    = help: if this is intentional, consider extracting the `Rc` initialization to a variable
+   = help: or if not, initilaize each element individually
 
 error: aborting due to previous error
 

tests/ui/ref_clone_in_vec_init/rc/simple_case.stderr

@@ -5,8 +5,9 @@ LL |     let v = vec![Rc::new("x".to_string()); 2];
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D clippy::ref-clone-in-vec-init` implied by `-D warnings`
-   = note: each `Rc` will point to the same allocation
+   = note: each element will point to the same `Rc` instance
    = help: if this is intentional, consider extracting the `Rc` initialization to a variable
+   = help: or if not, initilaize each element individually
 
 error: aborting due to previous error