better formatparam order

Author: nyurik

clippy_utils/src/macros.rs

@@ -599,8 +599,8 @@ pub struct FormatParam<'tcx> {
 
 impl<'tcx> FormatParam<'tcx> {
     fn new(
-        usage: FormatParamUsage,
         mut kind: FormatParamKind,
+        usage: FormatParamUsage,
         position: usize,
         inner: rpf::InnerSpan,
         values: &FormatArgsValues<'tcx>,
@@ -648,22 +648,22 @@ impl<'tcx> Count<'tcx> {
         Some(match count {
             rpf::Count::CountIs(val) => Self::Is(val, span_from_inner(values.format_string_span, inner?)),
             rpf::Count::CountIsName(name, _) => Self::Param(FormatParam::new(
-                usage,
                 FormatParamKind::Named(Symbol::intern(name)),
+                usage,
                 position?,
                 inner?,
                 values,
             )?),
             rpf::Count::CountIsParam(_) => Self::Param(FormatParam::new(
-                usage,
                 FormatParamKind::Numbered,
+                usage,
                 position?,
                 inner?,
                 values,
             )?),
             rpf::Count::CountIsStar(_) => Self::Param(FormatParam::new(
-                usage,
                 FormatParamKind::Starred,
+                usage,
                 position?,
                 inner?,
                 values,
@@ -837,13 +837,13 @@ impl<'tcx> FormatArgsExpn<'tcx> {
                 .map(|(position, parsed_arg, arg_span)| {
                     Some(FormatArg {
                         param: FormatParam::new(
-                            FormatParamUsage::Argument,
                             match parsed_arg.position {
                                 rpf::Position::ArgumentImplicitlyIs(_) => FormatParamKind::Implicit,
                                 rpf::Position::ArgumentIs(_) => FormatParamKind::Numbered,
                                 // NamedInline is handled by `FormatParam::new()`
                                 rpf::Position::ArgumentNamed(name) => FormatParamKind::Named(Symbol::intern(name)),
                             },
+                            FormatParamUsage::Argument,
                             position.value,
                             parsed_arg.position_span,
                             &values,