ValueMapper does not preserve inline assembly dialect when remapping the type

topperc · Amanieu · commit d1947abf64d4 · 2020-05-18T01:33:39.000+01:00
Bug report: https://bugs.llvm.org/show_bug.cgi?id=45291 Patch by Tomasz Miąsko Differential Revision: https://reviews.llvm.org/D80066
diff --git a/llvm/lib/Transforms/Utils/ValueMapper.cpp b/llvm/lib/Transforms/Utils/ValueMapper.cpp
@@ -369,7 +369,8 @@ Value *Mapper::mapValue(const Value *V) {
 
       if (NewTy != IA->getFunctionType())
         V = InlineAsm::get(NewTy, IA->getAsmString(), IA->getConstraintString(),
-                           IA->hasSideEffects(), IA->isAlignStack());
+                           IA->hasSideEffects(), IA->isAlignStack(),
+                           IA->getDialect());
     }
 
     return getVM()[V] = const_cast<Value *>(V);

Original file line number	Diff line number	Diff line change
`@@ -369,7 +369,8 @@ Value Mapper::mapValue(const Value V) {`
`369`	`369`
`370`	`370`	`if (NewTy != IA->getFunctionType())`
`371`	`371`	`V = InlineAsm::get(NewTy, IA->getAsmString(), IA->getConstraintString(),`
`372`		`- IA->hasSideEffects(), IA->isAlignStack());`
	`372`	`+ IA->hasSideEffects(), IA->isAlignStack(),`
	`373`	`+ IA->getDialect());`
`373`	`374`	`}`
`374`	`375`
`375`	`376`	`return getVM()[V] = const_cast<Value *>(V);`