Auto merge of #4480 - Turbo87:category-error, r=Turbo87

category: Show error page if data loading fails

also similar to #4476

Author: bors

app/routes/category.js

@@ -3,20 +3,22 @@ import Route from '@ember/routing/route';
 import { inject as service } from '@ember/service';
 
 export default class CategoryRoute extends Route {
-  @service notifications;
   @service router;
   @service store;
 
-  async model(params) {
+  async model(params, transition) {
+    let categoryName = params.category_id;
+
     try {
-      return await this.store.find('category', params.category_id);
+      return await this.store.find('category', categoryName);
     } catch (error) {
       if (error instanceof NotFoundError) {
-        this.notifications.error(`Category '${params.category_id}' does not exist`);
-        return this.router.replaceWith('index');
+        let title = `${categoryName}: Category not found`;
+        this.router.replaceWith('catch-all', { transition, title });
+      } else {
+        let title = `${categoryName}: Failed to load category data`;
+        this.router.replaceWith('catch-all', { transition, error, title, tryAgain: true });
       }
-
-      throw error;
     }
   }
 }

tests/routes/category-test.js

@@ -9,16 +9,22 @@ module('Route | category', function (hooks) {
   setupApplicationTest(hooks);
 
   test("shows an error message if the category can't be found", async function (assert) {
-    await visit('/categories/unknown');
-    assert.equal(currentURL(), '/');
-    assert.dom('[data-test-notification-message]').hasText("Category 'unknown' does not exist");
+    await visit('/categories/foo');
+    assert.equal(currentURL(), '/categories/foo');
+    assert.dom('[data-test-404-page]').exists();
+    assert.dom('[data-test-title]').hasText('foo: Category not found');
+    assert.dom('[data-test-go-back]').exists();
+    assert.dom('[data-test-try-again]').doesNotExist();
   });
 
   test('server error causes the error page to be shown', async function (assert) {
     this.server.get('/api/v1/categories/:categoryId', {}, 500);
 
-    await visit('/categories/error');
-    assert.equal(currentURL(), '/categories/error');
-    assert.dom('[data-test-error-message]').includesText('GET /api/v1/categories/error returned a 500');
+    await visit('/categories/foo');
+    assert.equal(currentURL(), '/categories/foo');
+    assert.dom('[data-test-404-page]').exists();
+    assert.dom('[data-test-title]').hasText('foo: Failed to load category data');
+    assert.dom('[data-test-go-back]').doesNotExist();
+    assert.dom('[data-test-try-again]').exists();
   });
 });