Newtype for AscribeUserType semi-traversable tuple

Author: eggyal

compiler/rustc_borrowck/src/type_check/mod.rs

@@ -1297,7 +1297,7 @@ impl<'a, 'tcx> TypeChecker<'a, 'tcx> {
                     );
                 }
             }
-            StatementKind::AscribeUserType(box (place, projection), variance) => {
+            StatementKind::AscribeUserType(box AscribeUserType(place, projection), variance) => {
                 let place_ty = place.ty(body, tcx).ty;
                 if let Err(terr) = self.relate_type_and_user_type(
                     place_ty,

compiler/rustc_middle/src/mir/mod.rs

@@ -1477,6 +1477,10 @@ impl<'tcx> UserTypeProjections {
     }
 }
 
+#[derive(Clone, Debug, TyEncodable, TyDecodable, Hash, HashStable, PartialEq)]
+#[derive(TypeFoldable, TypeVisitable)]
+pub struct AscribeUserType<'tcx>(pub Place<'tcx>, pub UserTypeProjection);
+
 /// Encodes the effect of a user-supplied type annotation on the
 /// subcomponents of a pattern. The effect is determined by applying the
 /// given list of projections to some underlying base type. Often,
@@ -1493,7 +1497,6 @@ impl<'tcx> UserTypeProjections {
 ///   `field[0]` (aka `.0`), indicating that the type of `s` is
 ///   determined by finding the type of the `.0` field from `T`.
 #[derive(Clone, Debug, TyEncodable, TyDecodable, Hash, HashStable, PartialEq)]
-#[derive(TypeFoldable, TypeVisitable)]
 pub struct UserTypeProjection {
     pub base: UserTypeAnnotationIndex,
     pub projs: Vec<ProjectionKind>,

compiler/rustc_middle/src/mir/pretty.rs

@@ -703,7 +703,7 @@ impl Debug for Statement<'_> {
             PlaceMention(ref place) => {
                 write!(fmt, "PlaceMention({place:?})")
             }
-            AscribeUserType(box (ref place, ref c_ty), ref variance) => {
+            AscribeUserType(box self::AscribeUserType(ref place, ref c_ty), ref variance) => {
                 write!(fmt, "AscribeUserType({place:?}, {variance:?}, {c_ty:?})")
             }
             Coverage(box mir::Coverage { ref kind }) => write!(fmt, "Coverage::{kind:?}"),

compiler/rustc_middle/src/mir/syntax.rs

@@ -3,7 +3,7 @@
 //! This is in a dedicated file so that changes to this file can be reviewed more carefully.
 //! The intention is that this file only contains datatype declarations, no code.
 
-use super::{BasicBlock, Const, Local, UserTypeProjection};
+use super::{AscribeUserType, BasicBlock, Const, Local};
 
 use crate::mir::coverage::CoverageKind;
 use crate::traits::Reveal;
@@ -359,7 +359,7 @@ pub enum StatementKind<'tcx> {
     /// When executed at runtime this is a nop.
     ///
     /// Disallowed after drop elaboration.
-    AscribeUserType(Box<(Place<'tcx>, UserTypeProjection)>, ty::Variance),
+    AscribeUserType(Box<AscribeUserType<'tcx>>, ty::Variance),
 
     /// Carries control-flow-sensitive information injected by `-Cinstrument-coverage`,
     /// such as where to generate physical coverage-counter-increments during codegen.

compiler/rustc_middle/src/mir/visit.rs

@@ -425,7 +425,7 @@ macro_rules! make_mir_visitor {
                         );
                     }
                     StatementKind::AscribeUserType(
-                        box (place, user_ty),
+                        box AscribeUserType(place, user_ty),
                         variance
                     ) => {
                         self.visit_ascribe_user_ty(place, $(& $mutability)? *variance, user_ty, location);

compiler/rustc_mir_build/src/build/expr/as_place.rs

@@ -482,7 +482,7 @@ impl<'a, 'tcx> Builder<'a, 'tcx> {
                         Statement {
                             source_info,
                             kind: StatementKind::AscribeUserType(
-                                Box::new((
+                                Box::new(AscribeUserType(
                                     place,
                                     UserTypeProjection { base: annotation_index, projs: vec![] },
                                 )),
@@ -509,7 +509,7 @@ impl<'a, 'tcx> Builder<'a, 'tcx> {
                         Statement {
                             source_info,
                             kind: StatementKind::AscribeUserType(
-                                Box::new((
+                                Box::new(AscribeUserType(
                                     Place::from(temp),
                                     UserTypeProjection { base: annotation_index, projs: vec![] },
                                 )),

compiler/rustc_mir_build/src/build/matches/mod.rs

@@ -586,7 +586,10 @@ impl<'a, 'tcx> Builder<'a, 'tcx> {
                     Statement {
                         source_info: ty_source_info,
                         kind: StatementKind::AscribeUserType(
-                            Box::new((place, UserTypeProjection { base, projs: Vec::new() })),
+                            Box::new(AscribeUserType(
+                                place,
+                                UserTypeProjection { base, projs: Vec::new() },
+                            )),
                             // We always use invariant as the variance here. This is because the
                             // variance field from the ascription refers to the variance to use
                             // when applying the type to the value being matched, but this
@@ -2149,7 +2152,7 @@ impl<'a, 'tcx> Builder<'a, 'tcx> {
                 Statement {
                     source_info,
                     kind: StatementKind::AscribeUserType(
-                        Box::new((
+                        Box::new(AscribeUserType(
                             ascription.source,
                             UserTypeProjection { base, projs: Vec::new() },
                         )),

compiler/rustc_mir_transform/src/remove_zsts.rs

@@ -110,7 +110,7 @@ impl<'tcx> MutVisitor<'tcx> for Replacer<'_, 'tcx> {
             }
             StatementKind::Deinit(box place)
             | StatementKind::SetDiscriminant { box place, variant_index: _ }
-            | StatementKind::AscribeUserType(box (place, _), _)
+            | StatementKind::AscribeUserType(box AscribeUserType(place, _), _)
             | StatementKind::Retag(_, box place)
             | StatementKind::PlaceMention(box place)
             | StatementKind::FakeRead(box FakeReadCauseAndPlace(_, place)) => Some(place),