Merge #271: add decode_raw_transaction

794d040 add `decode_raw_transaction` (thesimplekid)

Pull request description:

ACKs for top commit:
  apoelstra:
    ACK 794d040

Tree-SHA512: 7a3e7f938daf966b02d511027433babc451e814f5a01ebdda495592134e048dfe99763440e8e3f340443e99ef4502f722eb52e7073cfecca2c19ad07b01a14e7

Author: apoelstra

client/src/client.rs

@@ -785,6 +785,16 @@ pub trait RpcApi: Sized {
         deserialize_hex(&hex)
     }
 
+    fn decode_raw_transaction<R: RawTx>(
+        &self,
+        tx: R,
+        is_witness: Option<bool>,
+    ) -> Result<json::DecodeRawTransactionResult> {
+        let mut args = [tx.raw_hex().into(), opt_into_json(is_witness)?];
+        let defaults = [null()];
+        self.call("decoderawtransaction", handle_defaults(&mut args, &defaults))
+    }
+
     fn fund_raw_transaction<R: RawTx>(
         &self,
         tx: R,

integration_test/src/main.rs

@@ -169,6 +169,7 @@ fn main() {
     test_invalidate_block_reconsider_block(&cl);
     test_key_pool_refill(&cl);
     test_create_raw_transaction(&cl);
+    test_decode_raw_transaction(&cl);
     test_fund_raw_transaction(&cl);
     test_test_mempool_accept(&cl);
     test_wallet_create_funded_psbt(&cl);
@@ -646,6 +647,35 @@ fn test_create_raw_transaction(cl: &Client) {
     assert_eq!(hex, serialize(&tx).to_hex());
 }
 
+fn test_decode_raw_transaction(cl: &Client) {
+    let options = json::ListUnspentQueryOptions {
+        minimum_amount: Some(btc(2)),
+        ..Default::default()
+    };
+    let unspent = cl.list_unspent(Some(6), None, None, None, Some(options)).unwrap();
+    let unspent = unspent.into_iter().nth(0).unwrap();
+
+    let input = json::CreateRawTransactionInput {
+        txid: unspent.txid,
+        vout: unspent.vout,
+        sequence: None,
+    };
+    let mut output = HashMap::new();
+    output.insert(RANDOM_ADDRESS.to_string(), btc(1));
+
+    let tx =
+        cl.create_raw_transaction(&[input.clone()], &output, Some(500_000), Some(true)).unwrap();
+    let hex = cl.create_raw_transaction_hex(&[input], &output, Some(500_000), Some(true)).unwrap();
+
+    let decoded_transaction = cl.decode_raw_transaction(hex, None).unwrap();
+
+    assert_eq!(tx.txid(), decoded_transaction.txid);
+    assert_eq!(500_000, decoded_transaction.locktime);
+
+    assert_eq!(decoded_transaction.vin[0].txid.unwrap(), unspent.txid);
+    assert_eq!(decoded_transaction.vout[0].clone().value, btc(1));
+}
+
 fn test_fund_raw_transaction(cl: &Client) {
     let addr = cl.get_new_address(None, None).unwrap();
     let mut output = HashMap::new();

json/src/lib.rs

@@ -1717,6 +1717,20 @@ pub struct FinalizePsbtResult {
     pub complete: bool,
 }
 
+/// Model for decode transaction
+#[derive(Clone, PartialEq, Eq, Debug, Deserialize, Serialize)]
+pub struct DecodeRawTransactionResult {
+    pub txid: bitcoin::Txid,
+    pub hash: bitcoin::Wtxid,
+    pub size: u32,
+    pub vsize: u32,
+    pub weight: u32,
+    pub version: u32,
+    pub locktime: u32,
+    pub vin: Vec<GetRawTransactionResultVin>,
+    pub vout: Vec<GetRawTransactionResultVout>,
+}
+
 /// Models the result of "getchaintips"
 pub type GetChainTipsResult = Vec<GetChainTipsResultTip>;