Merge #154: Remove leading double colons

49ba623 Remove leading double colons (Tobin C. Harding)

Pull request description:

  Leading double colons are a relic of Rust edition 2015, we do not need to use them any more now we are on edition 2018.

ACKs for top commit:
  apoelstra:
    ACK 49ba623

Tree-SHA512: 89dcea7c605f1d152646b45c084ace10cb21f082688839831adb97f7368475f01085aa725f2ae989c3be26e42379fafb9ca22713dcd93b3a78c9323826602613

Author: apoelstra

src/cmp.rs

@@ -20,24 +20,24 @@ pub fn fixed_time_eq(a: &[u8], b: &[u8]) -> bool {
 
     let mut r: u8 = 0;
     for i in 0..count {
-        let mut rs = unsafe { ::core::ptr::read_volatile(&r) };
+        let mut rs = unsafe { core::ptr::read_volatile(&r) };
         rs |= lhs[i] ^ rhs[i];
-        unsafe { ::core::ptr::write_volatile(&mut r, rs); }
+        unsafe { core::ptr::write_volatile(&mut r, rs); }
     }
     {
-        let mut t = unsafe { ::core::ptr::read_volatile(&r) };
+        let mut t = unsafe { core::ptr::read_volatile(&r) };
         t |= t >> 4;
-        unsafe { ::core::ptr::write_volatile(&mut r, t); }
+        unsafe { core::ptr::write_volatile(&mut r, t); }
     }
     {
-        let mut t = unsafe { ::core::ptr::read_volatile(&r) };
+        let mut t = unsafe { core::ptr::read_volatile(&r) };
         t |= t >> 2;
-        unsafe { ::core::ptr::write_volatile(&mut r, t); }
+        unsafe { core::ptr::write_volatile(&mut r, t); }
     }
     {
-        let mut t = unsafe { ::core::ptr::read_volatile(&r) };
+        let mut t = unsafe { core::ptr::read_volatile(&r) };
         t |= t >> 1;
-        unsafe { ::core::ptr::write_volatile(&mut r, t); }
+        unsafe { core::ptr::write_volatile(&mut r, t); }
     }
     unsafe { (::core::ptr::read_volatile(&r) & 1) == 0 }
 }

src/lib.rs

@@ -49,9 +49,9 @@
 
 #[doc(hidden)]
 pub mod _export {
-    /// A re-export of ::core::*
+    /// A re-export of core::*
     pub mod _core {
-        pub use ::core::*;
+        pub use core::*;
     }
 }
 

src/sha256t.rs

@@ -67,8 +67,8 @@ impl<T: Tag> Ord for Hash<T> {
         cmp::Ord::cmp(&self.0, &other.0)
     }
 }
-impl<T: Tag> ::core::hash::Hash for Hash<T> {
-    fn hash<H: ::core::hash::Hasher>(&self, h: &mut H) {
+impl<T: Tag> core::hash::Hash for Hash<T> {
+    fn hash<H: core::hash::Hasher>(&self, h: &mut H) {
         self.0.hash(h)
     }
 }
@@ -167,8 +167,8 @@ macro_rules! sha256t_hash_newtype {
 }
 
 #[cfg(feature = "serde")]
-impl<T: Tag> ::serde::Serialize for Hash<T> {
-    fn serialize<S: ::serde::Serializer>(&self, s: S) -> Result<S::Ok, S::Error> {
+impl<T: Tag> serde::Serialize for Hash<T> {
+    fn serialize<S: serde::Serializer>(&self, s: S) -> Result<S::Ok, S::Error> {
         if s.is_human_readable() {
             s.collect_str(self)
         } else {
@@ -186,7 +186,7 @@ impl<T: Tag> Default for HexVisitor<T> {
 }
 
 #[cfg(feature = "serde")]
-impl<'de, T: Tag> ::serde::de::Visitor<'de> for HexVisitor<T> {
+impl<'de, T: Tag> serde::de::Visitor<'de> for HexVisitor<T> {
     type Value = Hash<T>;
 
     fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
@@ -195,7 +195,7 @@ impl<'de, T: Tag> ::serde::de::Visitor<'de> for HexVisitor<T> {
 
     fn visit_bytes<E>(self, v: &[u8]) -> Result<Self::Value, E>
     where
-        E: ::serde::de::Error,
+        E: serde::de::Error,
     {
         use core::str::FromStr;
         if let Ok(hex) = str::from_utf8(v) {
@@ -207,7 +207,7 @@ impl<'de, T: Tag> ::serde::de::Visitor<'de> for HexVisitor<T> {
 
     fn visit_str<E>(self, v: &str) -> Result<Self::Value, E>
     where
-        E: ::serde::de::Error,
+        E: serde::de::Error,
     {
         use core::str::FromStr;
         Hash::<T>::from_str(v).map_err(E::custom)
@@ -223,7 +223,7 @@ impl<T: Tag> Default for BytesVisitor<T> {
 }
 
 #[cfg(feature = "serde")]
-impl<'de, T: Tag> ::serde::de::Visitor<'de> for BytesVisitor<T> {
+impl<'de, T: Tag> serde::de::Visitor<'de> for BytesVisitor<T> {
     type Value = Hash<T>;
 
     fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
@@ -232,7 +232,7 @@ impl<'de, T: Tag> ::serde::de::Visitor<'de> for BytesVisitor<T> {
 
     fn visit_bytes<E>(self, v: &[u8]) -> Result<Self::Value, E>
     where
-        E: ::serde::de::Error,
+        E: serde::de::Error,
     {
         Hash::<T>::from_slice(v).map_err(|_| {
             // from_slice only errors on incorrect length
@@ -242,8 +242,8 @@ impl<'de, T: Tag> ::serde::de::Visitor<'de> for BytesVisitor<T> {
 }
 
 #[cfg(feature = "serde")]
-impl<'de, T: Tag> ::serde::Deserialize<'de> for Hash<T> {
-    fn deserialize<D: ::serde::Deserializer<'de>>(d: D) -> Result<Hash<T>, D::Error> {
+impl<'de, T: Tag> serde::Deserialize<'de> for Hash<T> {
+    fn deserialize<D: serde::Deserializer<'de>>(d: D) -> Result<Hash<T>, D::Error> {
         if d.is_human_readable() {
             d.deserialize_str(HexVisitor::<T>::default())
         } else {

src/util.rs

@@ -108,7 +108,7 @@ macro_rules! define_slice_to_be {
     ($name: ident, $type: ty) => {
         #[inline]
         pub fn $name(slice: &[u8]) -> $type {
-            assert_eq!(slice.len(), ::core::mem::size_of::<$type>());
+            assert_eq!(slice.len(), core::mem::size_of::<$type>());
             let mut res = 0;
             for i in 0..::core::mem::size_of::<$type>() {
                 res |= (slice[i] as $type) << (::core::mem::size_of::<$type>() - i - 1)*8;
@@ -121,7 +121,7 @@ macro_rules! define_slice_to_le {
     ($name: ident, $type: ty) => {
         #[inline]
         pub fn $name(slice: &[u8]) -> $type {
-            assert_eq!(slice.len(), ::core::mem::size_of::<$type>());
+            assert_eq!(slice.len(), core::mem::size_of::<$type>());
             let mut res = 0;
             for i in 0..::core::mem::size_of::<$type>() {
                 res |= (slice[i] as $type) << i*8;