Merge pull request #199 from rulasg/resolve-project-environment

feat(Resolve-ProjectParameters): Remove sticky project environment setting

Author: rulasg

Test/private/MockCall_Project700.ps1

@@ -170,7 +170,7 @@ function Get-Mock_Project_700 {
     $project.searchInTitle = @{}
     $project.searchInTitle.titleFilter = "development"
     $project.searchInTitle.Titles = $pActual.items.nodes.content.title | Where-Object { $_ -like "*development*" }
-    $project.searchInTitle.attributesDefault = @("Title", "id")
+    $project.searchInTitle.attributesDefault = @("Title", "id" , "RepositoryName")
     $project.searchInTitle.attributes = @("Title", "id", "url", "Status", "field-text")
 
     # SearchIn FieldName

Test/public/integrations/sync-ProjectItemsBetweenProjects.test.ps1

@@ -22,7 +22,7 @@ function Test_UpdateProjectItemsBetweenProjects{
 
     Assert-IsNull -Object $result
 
-    $staged = Get-ProjectItemStaged -Owner $owner -ProjectNumber $destinationProjectNumber
+    $staged = Get-ProjectItemStaged -Owner $destinationOwner -ProjectNumber $destinationProjectNumber
 
     $p = $p626.syncBtwPrj_625
 

Test/public/interactive_test/getproject.test.ps1

@@ -9,8 +9,10 @@ function Test_Get_Project_ItemId_Equal_Case_Sensitive {
     $item1 = "PVTI_lADOAlIw4c4BCe3Vzgec8pU"
     $item2 = "PVTI_lADOAlIw4c4BCe3Vzgec8pu"
 
+    Set-ProjectHelperEnvironment -Owner $owner -ProjectNumber $projectNumber
+
     # Act
-    $result = Get-Project -owner $owner -ProjectNumber $ProjectNumber
+    $result = Get-Project
     Assert-Count -Expected $p.items.totalCount -Presented $result.items.keys
 
     $result1 = Get-ProjectItem -ItemId $item1

Test/public/issues/Add-IssuePullRequestComment.test.ps1

@@ -22,7 +22,7 @@ function Test_AddComment_SUCCESS_Using_Cache{
 
 function Test_AddComment_SUCCESS_Using_Direct{
 
-    $p = Get-Mock_Project_700
+    $p = Get-Mock_Project_700 
     $i = $p.Issue
     $id = $i.id
     $contentId = $i.contentId

Test/public/issues/Get-ProjectIssue.test.ps1

@@ -1,12 +1,12 @@
 function Test_GetProjectIssue{
 
-    $p = Get-Mock_Project_700 ; $Owner = $p.owner ; $projectNumber = $p.number
+    $p = Get-Mock_Project_700
     $i = $p.issue
 
     MockCallJson -Command "Invoke-GetIssueOrPullRequest -Url $($i.url)" -FileName "invoke-GetIssueOrPullRequest-26.json"
 
     # Act
-    $result = Get-ProjectIssue -Url $i.url
+    $result = Get-ProjectIssue -Url $i.url 
 
     Assert-AreEqual -Expected $i.contentId -Presented $result.id
     Assert-AreEqual -Expected $i.title -Presented $result.title

Test/public/issues/Remove-ProjectIssue.test.ps1

@@ -9,7 +9,7 @@ function Test_RemoveProjectIssue_SUCCESS {
     MockCallJson -Command "Invoke-GetIssueOrPullRequest -Url $($i.url)" -fileName $i.getIssueOrPullRequestMockFile
     MockCallJson -Command "Invoke-AddItemToProject -ProjectId $($p.id) -ContentId $($i.id)" -fileName $i.addIssueToOProjectMockFile
     $itemId = Add-ProjectItem -owner $owner -projectNumber $projectNumber -Url $i.url
-    $item = Get-ProjectItem -Id $itemId
+    $item = Get-ProjectItem -Id $itemId -owner $owner -projectNumber $projectNumber
     Assert-AreEqual -expected $i.id -Presented $item.contentId
 
     MockCallJson -Command "Invoke-RemoveItemFromProject -ProjectId $($p.id) -ItemId $($i.itemId)" -fileName $i.removeIssueFromProjectMockFile
@@ -19,11 +19,11 @@ function Test_RemoveProjectIssue_SUCCESS {
 
     # Assert
     Assert-AreEqual -Expected $i.url -Presented $result
-    Assert-IsFalse -Condition $(Test-ProjectItem -Url $i.url)
+    Assert-IsFalse -Condition $(Test-ProjectItem -Url $i.url -Owner $owner -ProjectNumber $projectNumber)
 
-    # Remove issue assocaited
+    # Remove issue associated
     $itemId = Add-ProjectItem -owner $owner -projectNumber $projectNumber -Url $i.url
-    Assert-IsTrue -Condition $(Test-ProjectItem -Url $i.url)
+    Assert-IsTrue -Condition $(Test-ProjectItem -Url $i.url -Owner $owner -ProjectNumber $projectNumber)
     MockCallJson -Command "Invoke-RemoveIssue -IssueId $($i.id)" -FileName "invoke-removeissue-any.json"
 
     # Act

Test/public/items/project_item_draftissue.test.ps1

@@ -11,10 +11,8 @@ function Test_NewProjectDraftIssue {
     # Act
     $draftIssueId = New-ProjectDraftIssueDirect -Owner $owner -ProjectNumber $projectNumber -Title $title -Body $body
 
-
-    $item = Get-ProjectItem -ItemId $draftIssueId
-
     # Assert
+    $item = Get-ProjectItem -ItemId $draftIssueId -Owner $owner -ProjectNumber $projectNumber
     Assert-AreEqual -Expected $draftIssueId -Presented $item.id
     Assert-AreEqual -Expected $title -Presented $item.Title
     Assert-AreEqual -Expected $body -Presented $item.Body

Test/public/items/use_order.test.ps1

@@ -12,13 +12,34 @@ function Test_UserOrder_Success{
 
 }
 
-function Test_UserOrder_Success_GetItem{
+function Test_UserOrder_Success_GetItem_FAIL_NO_ENVIRONMENT{
     MockCall_GetProject_700
 
     $p = Get-Mock_Project_700 ; $owner = $p.owner ; $projectNumber = $p.number
 
+    # We need to have the environment set to get item details in PassThru
     $list = Search-ProjectItem -Owner $owner -ProjectNumber $projectNumber -IncludeDone
 
+    # Act
+    $hasthorwn = $false
+    try {
+        $list | Use-Order 1
+    } catch {
+        $hasthorwn = $true
+        Assert-IsTrue -Condition $_.Exception.Message.StartsWith("ProjectEnvironment is required.")
+    }
+    Assert-IsTrue -Condition $hasthorwn
+}
+
+function Test_UserOrder_Success_GetItem{
+    MockCall_GetProject_700
+
+    $p = Get-Mock_Project_700 ; $owner = $p.owner ; $projectNumber = $p.number
+
+    # We need to have the environment set to get item details in PassThru
+    Set-ProjectHelperEnvironment -Owner $owner -ProjectNumber $projectNumber
+    $list = Search-ProjectItem -IncludeDone
+
     # Act
     $result = $list | Use-Order 1 -PassThru
 
@@ -33,7 +54,9 @@ function Test_UserOrder_Success_OpenBrowser{
 
     MockCallToNull -command "Invoke-ProjectHelperOpenUrl -Url $url"
 
-    $list = Search-ProjectItem -Owner $owner -ProjectNumber $projectNumber -IncludeDone
+    # We need to have the environment set to get item details in PassThru
+    Set-ProjectHelperEnvironment -Owner $owner -ProjectNumber $projectNumber
+    $list = Search-ProjectItem -IncludeDone
 
     # Act
     $result = $list | Use-Order $order -OpenInBrowser
@@ -48,7 +71,9 @@ function Test_UserOrder_Success_Passthru{
     $p = Get-Mock_Project_700 ; $owner = $p.owner ; $projectNumber = $p.number
     $order = $p.issue.order ; $id = $p.issue.id
 
-    $list = Search-ProjectItem -Owner $owner -ProjectNumber $projectNumber -IncludeDone
+    # We need to have the environment set to get item details in PassThru
+    Set-ProjectHelperEnvironment -Owner $owner -ProjectNumber $projectNumber
+    $list = Search-ProjectItem -IncludeDone
 
     # Act
     $result = $list | Use-Order $order -PassThru

Test/public/project_item.searchprojectitem.test.ps1

@@ -7,18 +7,22 @@ function Test_SearchProjectItem_Basic_SUCCESS {
     $p = Get-Mock_Project_700
     $Owner = $p.owner
     $ProjectNumber = $p.number
-    $filter = $p.searchInTitle.titleFilter
-    $expected = $p.searchInTitle.Titles.Count
+    $s = $p.searchInTitle
+    $filter = $s.titleFilter
+    $expected = $s.Titles.Count
+    $defautlAttrs = $s.attributesDefault
 
     $result = Search-ProjectItem -Owner $Owner -ProjectNumber $ProjectNumber -Filter $filter
     Assert-Count -Expected $expected -Presented $result
 
-    # Default attributes should be id + Title
+    # Default attributes should be id + Title + RepositoryName
     foreach($r in $result){
         $props = $r.PSObject.Properties.Name
-        Assert-Count -Expected 2 -Presented $props
-        Assert-Contains -Expected "id" -Presented $props
-        Assert-Contains -Expected "Title" -Presented $props
+
+        Assert-Count -Expected $defautlAttrs.Count -Presented $props
+        $defautlAttrs | ForEach-Object -Process {
+            Assert-Contains -Expected $_ -Presented $props
+        }
     }
 }
 

Test/public/project_item.test.ps1

@@ -192,7 +192,7 @@ function Test_TestProjectItem_Success{
 
     # Not found
 
-    $result = Test-ProjectItem -Url "https://github.com/octodemo/Project-700/issues/999"
+    $result = Test-ProjectItem -Url "https://github.com/octodemo/Project-700/issues/999" -Owner $owner -ProjectNumber $projectNumber
     Assert-IsFalse -Condition $result
 
 }