Skip to content

Old thor version can cause errors from Ruby 2.5 #239

@norbertszivos

Description

@norbertszivos

We are using Rails 5.2.4 and Ruby 2.5.x and your awesome gem as well. After some gem updates the thor gem version was updated to 0.20.3 and when I try to run a rake command like bundle exec rake -T got this error: TypeError: NameErrorCheckers is not a module

After a long investigation I realised that the thor gem caused this because they start to support did_you_mean library. The problem is that this support is old and in the mean time the did_you_mean library was changed from
https://github.com/ruby/did_you_mean/blob/v1.1.3/lib/did_you_mean/spell_checkers/name_error_checkers.rb (this is using Ruby 2.4)
to
https://github.com/ruby/did_you_mean/blob/v1.2.0/lib/did_you_mean/spell_checkers/name_error_checkers.rb (this is using Ruby 2.5)

The thor gem was updated so version 1.x can solve the issue, but your gem does not let us to update this gem. The thor gem should stay on 0.20.0 because of that.

Could you update your thor support, please?

Metadata

Metadata

Assignees

No one assigned

    Labels

    dependenciesPull requests that update a dependency fileduplicate

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions