From 85da11f904a35b47353d9b8d1fbde9dffc84c19e Mon Sep 17 00:00:00 2001 From: Stefanni Brasil Date: Tue, 5 May 2026 16:11:07 -0600 Subject: [PATCH 1/7] Refactor requests controller Moving view instances to a View Object. --- app/controllers/requests_controller.rb | 20 +---- app/models/view/requests.rb | 84 +++++++++++++++++++ .../_calculate_product_totals.html.erb | 2 +- app/views/requests/_new.html.erb | 2 +- app/views/requests/_request_row.html.erb | 2 +- app/views/requests/index.html.erb | 18 ++-- 6 files changed, 98 insertions(+), 30 deletions(-) create mode 100644 app/models/view/requests.rb diff --git a/app/controllers/requests_controller.rb b/app/controllers/requests_controller.rb index ce5677da0c..5dea6b16a3 100644 --- a/app/controllers/requests_controller.rb +++ b/app/controllers/requests_controller.rb @@ -3,27 +3,11 @@ class RequestsController < ApplicationController def index setup_date_range_picker - @requests = current_organization - .ordered_requests - .undiscarded - .during(helpers.selected_range) - .class_filter(filter_params) - @unfulfilled_requests_count = current_organization.requests.where(status: [:pending, :started]).during(helpers.selected_range).class_filter(filter_params).count - @paginated_requests = @requests.includes(:partner).page(params[:page]) - @calculate_product_totals = RequestsTotalItemsService.new(requests: @requests).calculate - @items = current_organization.items.alphabetized.select(:id, :name) - @partners = current_organization.partners.alphabetized.select(:id, :name, :status) - @statuses = Request.statuses.transform_keys(&:humanize) - @partner_users = User.where(id: @paginated_requests.map(&:partner_user_id)).select(:id, :name, :email) - @request_types = Request.request_types.transform_keys(&:humanize) - @selected_request_type = filter_params[:by_request_type] - @selected_request_item = filter_params[:by_request_item_id] - @selected_partner = filter_params[:by_partner] - @selected_status = filter_params[:by_status] + @request_info = View::Requests.from_params(params: params, organization: current_organization, helpers: helpers) respond_to do |format| format.html - format.csv { send_data Exports::ExportRequestService.new(@requests).generate_csv, filename: "Requests-#{Time.zone.today}.csv" } + format.csv { send_data Exports::ExportRequestService.new(@request_info.requests).generate_csv, filename: "Requests-#{Time.zone.today}.csv" } end end diff --git a/app/models/view/requests.rb b/app/models/view/requests.rb new file mode 100644 index 0000000000..55ae5cf90c --- /dev/null +++ b/app/models/view/requests.rb @@ -0,0 +1,84 @@ +module View + Requests = Data.define( + :requests, + :filters, + :paginated_requests, + :organization, + :helpers + ) do + include DateRangeHelper + + class << self + def filter_params(params = {}) + if params.key?(:filters) + params.require(:filters).permit(:by_request_item_id, :by_partner, :by_status, :by_request_type) + else + {} + end + end + + def from_params(params:, organization:, helpers:) + filters = filter_params(params) + + requests = organization + .ordered_requests + .undiscarded + .during(helpers.selected_range) + .class_filter(filters) + + paginated_requests = requests.includes(:partner).page(params[:page]) + + new(requests:, filters:, paginated_requests:, organization:, helpers:) + end + end + + def unfulfilled_requests_count + organization + .requests + .where(status: [:pending, :started]) + .during(helpers.selected_range) + .class_filter(filters) + .count + end + + def calculate_product_totals + RequestsTotalItemsService.new(requests: requests).calculate + end + + def items + organization.items.alphabetized.select(:id, :name) + end + + def partners + organization.partners.alphabetized.select(:id, :name, :status) + end + + def statuses + Request.statuses.transform_keys(&:humanize) + end + + def partner_users + User.where(id: paginated_requests.map(&:partner_user_id)).select(:id, :name, :email) + end + + def request_types + Request.request_types.transform_keys(&:humanize) + end + + def selected_request_type + filter_params[:by_request_type] + end + + def selected_request_item + filter_params[:by_request_item_id] + end + + def selected_partner + filter_params[:by_partner] + end + + def selected_status + filter_params[:by_status] + end + end +end diff --git a/app/views/requests/_calculate_product_totals.html.erb b/app/views/requests/_calculate_product_totals.html.erb index 5410923fb9..9b53f483af 100644 --- a/app/views/requests/_calculate_product_totals.html.erb +++ b/app/views/requests/_calculate_product_totals.html.erb @@ -16,7 +16,7 @@ - <% @calculate_product_totals.sort_by { |name, quantity| name.downcase }.each do |name, quantity| %> + <% @request_info.calculate_product_totals.sort_by { |name, quantity| name.downcase }.each do |name, quantity| %> <%= name %> <%= quantity %> diff --git a/app/views/requests/_new.html.erb b/app/views/requests/_new.html.erb index 9463b0b9ff..c6e774f1f9 100644 --- a/app/views/requests/_new.html.erb +++ b/app/views/requests/_new.html.erb @@ -10,7 +10,7 @@
<%= form_with(url: new_partners_request_path, method: :get) do |form| %>
- <%= form.collection_select(:partner_id, @partners.active, :id, :name, {include_blank: "Select a partner", required: true}, {class: "form-control mb-2"} ) %> + <%= form.collection_select(:partner_id, @request_info.partners.active, :id, :name, {include_blank: "Select a partner", required: true}, {class: "form-control mb-2"} ) %>
<%= submit_button({text: "Next", icon: nil, name: ""}) %> <% end %> diff --git a/app/views/requests/_request_row.html.erb b/app/views/requests/_request_row.html.erb index 58b4fdc3df..6af71f6798 100644 --- a/app/views/requests/_request_row.html.erb +++ b/app/views/requests/_request_row.html.erb @@ -2,7 +2,7 @@ <%= request_row.created_at.strftime("%m/%d/%Y") %> <%= request_row.partner.name %> - <% partner_user = @partner_users.find { |pu| pu.id == request_row.partner_user_id } %> + <% partner_user = @request_info.partner_users.find { |pu| pu.id == request_row.partner_user_id } %> <%= "#{partner_user&.formatted_email}" %> diff --git a/app/views/requests/index.html.erb b/app/views/requests/index.html.erb index 57462d00f5..d255f46d13 100644 --- a/app/views/requests/index.html.erb +++ b/app/views/requests/index.html.erb @@ -37,21 +37,21 @@
<%= form_tag(requests_path, method: :get) do |f| %>
- <% if @items.present? %> + <% if @request_info.items.present? %>
<%= filter_select(label: "Filter by item", scope: :by_request_item_id, collection: @items, selected: @selected_request_item) %>
<% end %> - <% if @partners.present? %> + <% if @request_info.partners.present? %>
<%= filter_select(scope: :by_partner, collection: @partners, selected: @selected_partner) %>
<% end %>
- <%= filter_select(scope: :by_request_type, collection: @request_types, key: :last, value: :first, selected: @selected_request_type) %> + <%= filter_select(scope: :by_request_type, collection: @request_info.request_types, key: :last, value: :first, selected: @selected_request_type) %>
- <%= filter_select(scope: :by_status, collection: @statuses, key: :last, value: :first, selected: @selected_status) %> + <%= filter_select(scope: :by_status, collection: @request_info.statuses, key: :last, value: :first, selected: @selected_status) %>
<%= label_tag "Date Range" %> @@ -67,13 +67,13 @@ <%= modal_button_to("#calculateTotals", {text: "Calculate Product Totals", icon: nil, size: "md", type: "success"}) %>
- <% if @unfulfilled_requests_count > 0 %> + <% if @request_info.unfulfilled_requests_count > 0 %> <%= print_button_to( print_unfulfilled_requests_path(format: :pdf, filters: filter_params.merge(date_range: date_range_params)), - text: "Print Unfulfilled Picklists (#{@unfulfilled_requests_count})", + text: "Print Unfulfilled Picklists (#{@request_info.unfulfilled_requests_count})", size: "md") %> <% end %> - <%= download_button_to(requests_path(format: :csv, filters: filter_params.merge(date_range: date_range_params)), {text: "Export Requests", size: "md"}) if @requests.any? %> + <%= download_button_to(requests_path(format: :csv, filters: filter_params.merge(date_range: date_range_params)), {text: "Export Requests", size: "md"}) if @request_info.requests.any? %> <%= modal_button_to("#newRequest", text: "New Quantity Request", icon: "plus", type: "success") if current_user.has_role?(Role::ORG_ADMIN, current_organization) %>
@@ -112,13 +112,13 @@ - <%= render partial: "request_row", collection: @paginated_requests %> + <%= render partial: "request_row", collection: @request_info.paginated_requests %>
- <%= paginate @paginated_requests %> + <%= paginate @request_info.paginated_requests %>
From 8089be6cb25bfff90506e634fc486dbaf6454e9b Mon Sep 17 00:00:00 2001 From: Stefanni Brasil Date: Tue, 5 May 2026 16:11:33 -0600 Subject: [PATCH 2/7] Remove unnecessary donations eager loading product_drive_participant This was raising a bullet error: GET /donations AVOID eager loading detected Donation => [:product_drive_participant] Remove from your query: .includes([:product_drive_participant]) --- app/models/view/donations.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/app/models/view/donations.rb b/app/models/view/donations.rb index 9518e98047..24e52d16f1 100644 --- a/app/models/view/donations.rb +++ b/app/models/view/donations.rb @@ -31,7 +31,6 @@ def from_params(params:, organization:, helpers:) .includes(:storage_location, :donation_site, :product_drive, - :product_drive_participant, :manufacturer, line_items: [:item]) .order(created_at: :desc) From b6908014b08854a31eb0616cf17fb3d0dd33e7b0 Mon Sep 17 00:00:00 2001 From: Stefanni Brasil Date: Tue, 5 May 2026 16:42:24 -0600 Subject: [PATCH 3/7] Refactor show action Moving view instances to a View Object to keep the controller clean. Add coverage for business logic --- app/models/view/requests.rb | 8 ++--- spec/models/view/requests_spec.rb | 59 +++++++++++++++++++++++++++++++ 2 files changed, 63 insertions(+), 4 deletions(-) create mode 100644 spec/models/view/requests_spec.rb diff --git a/app/models/view/requests.rb b/app/models/view/requests.rb index 55ae5cf90c..0a9697aa05 100644 --- a/app/models/view/requests.rb +++ b/app/models/view/requests.rb @@ -66,19 +66,19 @@ def request_types end def selected_request_type - filter_params[:by_request_type] + filters[:by_request_type] end def selected_request_item - filter_params[:by_request_item_id] + filters[:by_request_item_id] end def selected_partner - filter_params[:by_partner] + filters[:by_partner] end def selected_status - filter_params[:by_status] + filters[:by_status] end end end diff --git a/spec/models/view/requests_spec.rb b/spec/models/view/requests_spec.rb new file mode 100644 index 0000000000..dd556a96d0 --- /dev/null +++ b/spec/models/view/requests_spec.rb @@ -0,0 +1,59 @@ +RSpec.describe View::Requests do + describe "#unfulfilled_requests_count" do + it "returns the unfulfilled requests count for the given date range" do + organization = create(:organization) + create(:request, :pending, organization:) + create(:request, :started, organization:) + create(:request, :fulfilled, organization:) + + requests = View::Requests.from_params(params: {}, organization:, helpers:) + + expect(requests.unfulfilled_requests_count).to eq(2) + end + end + + describe "#calculate_product_totals" do + it "returns the product total items service" do + organization = create(:organization) + create(:request, :pending, organization:) + total_items_service_double = instance_double(RequestsTotalItemsService, calculate: {"Diaper" => 10}) + allow(RequestsTotalItemsService).to receive(:new).with(requests: organization.requests).and_return(total_items_service_double) + + requests = View::Requests.from_params(params: {}, organization:, helpers:) + + expect(requests.calculate_product_totals).to eq({"Diaper" => 10}) + end + end + + describe "selected filter params" do + it "returns the filter params given" do + organization = create(:organization) + create(:request, :pending, organization:) + params = ActionController::Parameters.new( + { + filters: { + by_request_type: "quantity", + by_request_item_id: "1", + by_partner: "A Local Partner", + by_status: "pending" + } + } + ).permit! + + requests = View::Requests.from_params(params:, organization:, helpers:) + + expect(requests.selected_request_type).to eq("quantity") + expect(requests.selected_request_item).to eq("1") + expect(requests.selected_partner).to eq("A Local Partner") + expect(requests.selected_status).to eq("pending") + end + end + + def helpers + Class.new do + def self.selected_range + (1.month.ago..2.days.from_now) + end + end + end +end From 72f9a3eac41e7ea4c725f3d5b92682a7b7420477 Mon Sep 17 00:00:00 2001 From: Stefanni Brasil Date: Mon, 11 May 2026 15:20:25 -0600 Subject: [PATCH 4/7] rename requests_info to avoid clashing with show request_info add coverage for Request model view --- app/controllers/requests_controller.rb | 13 +-- app/models/view/request_info.rb | 34 ++++++++ .../_calculate_product_totals.html.erb | 2 +- app/views/requests/_new.html.erb | 2 +- app/views/requests/_request_row.html.erb | 2 +- app/views/requests/index.html.erb | 18 ++-- app/views/requests/show.html.erb | 48 +++++------ spec/models/view/request_info_spec.rb | 82 +++++++++++++++++++ 8 files changed, 155 insertions(+), 46 deletions(-) create mode 100644 app/models/view/request_info.rb create mode 100644 spec/models/view/request_info_spec.rb diff --git a/app/controllers/requests_controller.rb b/app/controllers/requests_controller.rb index 5dea6b16a3..f0d625c7af 100644 --- a/app/controllers/requests_controller.rb +++ b/app/controllers/requests_controller.rb @@ -3,23 +3,16 @@ class RequestsController < ApplicationController def index setup_date_range_picker - @request_info = View::Requests.from_params(params: params, organization: current_organization, helpers: helpers) + @requests_info = View::Requests.from_params(params: params, organization: current_organization, helpers: helpers) respond_to do |format| format.html - format.csv { send_data Exports::ExportRequestService.new(@request_info.requests).generate_csv, filename: "Requests-#{Time.zone.today}.csv" } + format.csv { send_data Exports::ExportRequestService.new(@requests_info.requests).generate_csv, filename: "Requests-#{Time.zone.today}.csv" } end end def show - @request = current_organization.requests.find(params[:id]) - @item_requests = @request.item_requests.includes(:item) - - @inventory = View::Inventory.new(@request.organization_id) - @default_storage_location = @request.partner.default_storage_location_id || @request.organization.default_storage_location - @location = StorageLocation.find_by(id: @default_storage_location) - - @custom_units = Flipper.enabled?(:enable_packs) && @request.item_requests.any? { |item| item.request_unit } + @request_info = View::RequestInfo.from_params(params:, organization: current_organization) end # Clicking the "New Distribution" button will set the the request to started diff --git a/app/models/view/request_info.rb b/app/models/view/request_info.rb new file mode 100644 index 0000000000..8b4a4b3bd5 --- /dev/null +++ b/app/models/view/request_info.rb @@ -0,0 +1,34 @@ +module View + RequestInfo = Data.define( + :request + ) do + + class << self + def from_params(params:, organization:) + request = organization.requests.find(params[:id]) + + new(request:) + end + end + + def item_requests + request.item_requests.includes(:item) + end + + def inventory + View::Inventory.new(request.organization_id) + end + + def default_storage_location + request.partner.default_storage_location_id || request.organization.default_storage_location + end + + def location + StorageLocation.find_by(id: default_storage_location) + end + + def custom_units + Flipper.enabled?(:enable_packs) && request.item_requests.any? { |item| item.request_unit } + end + end +end diff --git a/app/views/requests/_calculate_product_totals.html.erb b/app/views/requests/_calculate_product_totals.html.erb index 9b53f483af..add383533f 100644 --- a/app/views/requests/_calculate_product_totals.html.erb +++ b/app/views/requests/_calculate_product_totals.html.erb @@ -16,7 +16,7 @@ - <% @request_info.calculate_product_totals.sort_by { |name, quantity| name.downcase }.each do |name, quantity| %> + <% @requests_info.calculate_product_totals.sort_by { |name, quantity| name.downcase }.each do |name, quantity| %> <%= name %> <%= quantity %> diff --git a/app/views/requests/_new.html.erb b/app/views/requests/_new.html.erb index c6e774f1f9..a4a1c075e9 100644 --- a/app/views/requests/_new.html.erb +++ b/app/views/requests/_new.html.erb @@ -10,7 +10,7 @@
<%= form_with(url: new_partners_request_path, method: :get) do |form| %>
- <%= form.collection_select(:partner_id, @request_info.partners.active, :id, :name, {include_blank: "Select a partner", required: true}, {class: "form-control mb-2"} ) %> + <%= form.collection_select(:partner_id, @requests_info.partners.active, :id, :name, {include_blank: "Select a partner", required: true}, {class: "form-control mb-2"} ) %>
<%= submit_button({text: "Next", icon: nil, name: ""}) %> <% end %> diff --git a/app/views/requests/_request_row.html.erb b/app/views/requests/_request_row.html.erb index 6af71f6798..471ae890c7 100644 --- a/app/views/requests/_request_row.html.erb +++ b/app/views/requests/_request_row.html.erb @@ -2,7 +2,7 @@ <%= request_row.created_at.strftime("%m/%d/%Y") %> <%= request_row.partner.name %> - <% partner_user = @request_info.partner_users.find { |pu| pu.id == request_row.partner_user_id } %> + <% partner_user = @requests_info.partner_users.find { |pu| pu.id == request_row.partner_user_id } %> <%= "#{partner_user&.formatted_email}" %> diff --git a/app/views/requests/index.html.erb b/app/views/requests/index.html.erb index d255f46d13..42d9d323f5 100644 --- a/app/views/requests/index.html.erb +++ b/app/views/requests/index.html.erb @@ -37,21 +37,21 @@
<%= form_tag(requests_path, method: :get) do |f| %>
- <% if @request_info.items.present? %> + <% if @requests_info.items.present? %>
<%= filter_select(label: "Filter by item", scope: :by_request_item_id, collection: @items, selected: @selected_request_item) %>
<% end %> - <% if @request_info.partners.present? %> + <% if @requests_info.partners.present? %>
<%= filter_select(scope: :by_partner, collection: @partners, selected: @selected_partner) %>
<% end %>
- <%= filter_select(scope: :by_request_type, collection: @request_info.request_types, key: :last, value: :first, selected: @selected_request_type) %> + <%= filter_select(scope: :by_request_type, collection: @requests_info.request_types, key: :last, value: :first, selected: @selected_request_type) %>
- <%= filter_select(scope: :by_status, collection: @request_info.statuses, key: :last, value: :first, selected: @selected_status) %> + <%= filter_select(scope: :by_status, collection: @requests_info.statuses, key: :last, value: :first, selected: @selected_status) %>
<%= label_tag "Date Range" %> @@ -67,13 +67,13 @@ <%= modal_button_to("#calculateTotals", {text: "Calculate Product Totals", icon: nil, size: "md", type: "success"}) %>
- <% if @request_info.unfulfilled_requests_count > 0 %> + <% if @requests_info.unfulfilled_requests_count > 0 %> <%= print_button_to( print_unfulfilled_requests_path(format: :pdf, filters: filter_params.merge(date_range: date_range_params)), - text: "Print Unfulfilled Picklists (#{@request_info.unfulfilled_requests_count})", + text: "Print Unfulfilled Picklists (#{@requests_info.unfulfilled_requests_count})", size: "md") %> <% end %> - <%= download_button_to(requests_path(format: :csv, filters: filter_params.merge(date_range: date_range_params)), {text: "Export Requests", size: "md"}) if @request_info.requests.any? %> + <%= download_button_to(requests_path(format: :csv, filters: filter_params.merge(date_range: date_range_params)), {text: "Export Requests", size: "md"}) if @requests_info.requests.any? %> <%= modal_button_to("#newRequest", text: "New Quantity Request", icon: "plus", type: "success") if current_user.has_role?(Role::ORG_ADMIN, current_organization) %>
@@ -112,13 +112,13 @@ - <%= render partial: "request_row", collection: @request_info.paginated_requests %> + <%= render partial: "request_row", collection: @requests_info.paginated_requests %>
- <%= paginate @request_info.paginated_requests %> + <%= paginate @requests_info.paginated_requests %>
diff --git a/app/views/requests/show.html.erb b/app/views/requests/show.html.erb index 19a44d5cd5..b3bd1f21d2 100644 --- a/app/views/requests/show.html.erb +++ b/app/views/requests/show.html.erb @@ -2,10 +2,10 @@
- <% content_for :title, "Requests - #{@request.id} - #{current_organization.name}" %> + <% content_for :title, "Requests - #{@request_info.request.id} - #{current_organization.name}" %>

Request - from <%= @request.partner.name %> + from <%= @request_info.request.partner.name %>

@@ -15,8 +15,8 @@ <% end %>
  • <%= link_to "Requests", requests_path %>
    • -
  • Request from <%= @request.partner.name %> - at <%= @request.created_at.to_fs(:distribution_date) %>
    • +
  • Request from <%= @request_info.request.partner.name %> + at <%= @request_info.request.created_at.to_fs(:distribution_date) %>
    • @@ -29,7 +29,7 @@
    -

    This request was sent on <%= @request.created_at.to_fs(:distribution_date) %>

    +

    This request was sent on <%= @request_info.request.created_at.to_fs(:distribution_date) %>

    @@ -44,11 +44,11 @@ - - - - - + + + + +
    <%= @request.partner.name %><%= @request.partner_user&.formatted_email %><%= @request.request_type&.humanize %><%= render partial: "status", locals: {status: @request.status} %><%= @request.comments || 'None' %><%= @request_info.request.partner.name %><%= @request_info.request.partner_user&.formatted_email %><%= @request_info.request.request_type&.humanize %><%= render partial: "status", locals: {status: @request_info.request.status} %><%= @request_info.request.comments || 'None' %>
    @@ -67,36 +67,36 @@ Item Quantity - <% if @custom_units %> + <% if @request_info.custom_units %> Units (if applicable) <% end %> - <% if @default_storage_location %> + <% if @request_info.default_storage_location %> Default storage location inventory <% end %> Total Inventory - <% @item_requests.each do |item_request| %> + <% @request_info.item_requests.each do |item_request| %> <%= item_request.item_name %> <%= item_request.quantity %> - <% if @custom_units %> + <% if @request_info.custom_units %> <%= item_request.request_unit&.pluralize(item_request.quantity.to_i) %> <% end %> - <% if @default_storage_location %> - <% on_hand_for_location = @inventory.quantity_for(storage_location: @location&.id, item_id: item_request.item_id) %> + <% if @request_info.default_storage_location %> + <% on_hand_for_location = @request_info.inventory.quantity_for(storage_location: @request_info.location&.id, item_id: item_request.item_id) %> <%= on_hand_for_location&.positive? ? on_hand_for_location : 'N/A' %> <% end %> - <% on_hand = @inventory.quantity_for(item_id: item_request.item_id) %> + <% on_hand = @request_info.inventory.quantity_for(item_id: item_request.item_id) %> <%= on_hand || 0 %> <% end %> Total (Quota) - <%= @request.total_items %> - <%= quota_display(@request.partner) %> + <%= @request_info.request.total_items %> + <%= quota_display(@request_info.request.partner) %> @@ -104,11 +104,11 @@
    - <%= submit_button_to start_request_path(@request), {text: "Fulfill request", size: "md"} unless @request.distribution %> - <%= view_button_to(distribution_path(@request.distribution), {text: "View Associated Distribution", size: "md"}) if @request.distribution %> - <%= print_button_to print_picklist_request_path(@request), { format: :pdf, text: "Print", size: "md" } %> - <% unless @request.status_fulfilled? %> - <%= button_to 'Cancel', new_request_cancelation_path(request_id: @request.id), + <%= submit_button_to start_request_path(@request_info.request), {text: "Fulfill request", size: "md"} unless @request_info.request.distribution %> + <%= view_button_to(distribution_path(@request_info.request.distribution), {text: "View Associated Distribution", size: "md"}) if @request_info.request.distribution %> + <%= print_button_to print_picklist_request_path(@request_info.request), { format: :pdf, text: "Print", size: "md" } %> + <% unless @request_info.request.status_fulfilled? %> + <%= button_to 'Cancel', new_request_cancelation_path(request_id: @request_info.request.id), method: :get, data: { disable_with: "Please wait..." }, form_class: 'd-inline', class: 'btn btn-danger btn-md' %> <% end %>
    diff --git a/spec/models/view/request_info_spec.rb b/spec/models/view/request_info_spec.rb new file mode 100644 index 0000000000..be4c9fce01 --- /dev/null +++ b/spec/models/view/request_info_spec.rb @@ -0,0 +1,82 @@ +RSpec.describe View::RequestInfo do + describe "#default_storage_location" do + context "when the request partner has a default_storage_location_id" do + it "returns the request partner's default_storage_location_id" do + storage_location = build(:storage_location) + organization = build(:organization) + request = create( + :request, + partner: build(:partner, default_storage_location_id: storage_location.id), + organization: + ) + + request = View::RequestInfo.from_params(params: {id: request.id}, organization:) + + expect(request.default_storage_location).to eq(storage_location.id) + end + end + + context "when the request organization has a default_storage_location_id" do + it "returns the request organization's default_storage_location_id" do + organization = build(:organization) + storage_location = build(:storage_location, organization:) + organization.update!(default_storage_location: storage_location.id) + request = create( + :request, + organization: + ) + + request = View::RequestInfo.from_params(params: {id: request.id}, organization:) + + expect(request.default_storage_location).to eq(storage_location.id) + end + end + end + + describe "#custom_units" do + context "when a request has request units for an item request" do + context "when enable_packs is disabled" do + it "returns false" do + organization = build(:organization) + item = build(:item, name: "First item") + create(:item_unit, item: item, name: "flat") + request = create( + :request, + :with_item_requests, + organization:, + request_items: [ + {item_id: item.id, quantity: '559', request_unit: 'flat'} + ] + ) + + request = View::RequestInfo.from_params(params: {id: request.id}, organization:) + + expect(request.custom_units).to be_falsey + end + end + + context "when enable_packs is enabled" do + it "returns true" do + Flipper.enable(:enable_packs) + + organization = build(:organization) + item = build(:item, name: "First item") + create(:item_unit, item: item, name: "flat") + request = create( + :request, + :with_item_requests, + organization:, + request_items: [ + {item_id: item.id, quantity: '559', request_unit: 'flat'}, + ] + ) + request = View::RequestInfo.from_params(params: {id: request.id}, organization:) + + expect(request.custom_units).to be_truthy + + Flipper.disable(:enable_packs) + end + end + end + end +end From 9a694c4c45f2770cd618df498690b198165009c5 Mon Sep 17 00:00:00 2001 From: Stefanni Brasil Date: Mon, 11 May 2026 15:58:01 -0600 Subject: [PATCH 5/7] Create factories only when necessary --- spec/models/view/request_info_spec.rb | 2 +- spec/models/view/requests_spec.rb | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/spec/models/view/request_info_spec.rb b/spec/models/view/request_info_spec.rb index be4c9fce01..ea207260cf 100644 --- a/spec/models/view/request_info_spec.rb +++ b/spec/models/view/request_info_spec.rb @@ -34,7 +34,7 @@ end describe "#custom_units" do - context "when a request has request units for an item request" do + context "when there are request units for an item request" do context "when enable_packs is disabled" do it "returns false" do organization = build(:organization) diff --git a/spec/models/view/requests_spec.rb b/spec/models/view/requests_spec.rb index dd556a96d0..40794a3d17 100644 --- a/spec/models/view/requests_spec.rb +++ b/spec/models/view/requests_spec.rb @@ -1,7 +1,7 @@ RSpec.describe View::Requests do describe "#unfulfilled_requests_count" do - it "returns the unfulfilled requests count for the given date range" do - organization = create(:organization) + it "returns the unfulfilled requests count" do + organization = build(:organization) create(:request, :pending, organization:) create(:request, :started, organization:) create(:request, :fulfilled, organization:) @@ -13,9 +13,9 @@ end describe "#calculate_product_totals" do - it "returns the product total items service" do - organization = create(:organization) - create(:request, :pending, organization:) + it "returns the calculated product total items" do + organization = build(:organization) + build(:request, :pending, organization:) total_items_service_double = instance_double(RequestsTotalItemsService, calculate: {"Diaper" => 10}) allow(RequestsTotalItemsService).to receive(:new).with(requests: organization.requests).and_return(total_items_service_double) @@ -26,9 +26,9 @@ end describe "selected filter params" do - it "returns the filter params given" do - organization = create(:organization) - create(:request, :pending, organization:) + it "returns the given filter params" do + organization = build(:organization) + build(:request, :pending, organization:) params = ActionController::Parameters.new( { filters: { @@ -50,7 +50,7 @@ end def helpers - Class.new do + Module.new do def self.selected_range (1.month.ago..2.days.from_now) end From 1f08698c3f2a443fc4fe7d14d6dd2015949181de Mon Sep 17 00:00:00 2001 From: Stefanni Brasil Date: Mon, 11 May 2026 17:37:34 -0600 Subject: [PATCH 6/7] Rename filter variables with the view object instance from the controller --- app/views/requests/index.html.erb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/views/requests/index.html.erb b/app/views/requests/index.html.erb index 42d9d323f5..6cde5bfb30 100644 --- a/app/views/requests/index.html.erb +++ b/app/views/requests/index.html.erb @@ -39,19 +39,19 @@
    <% if @requests_info.items.present? %>
    - <%= filter_select(label: "Filter by item", scope: :by_request_item_id, collection: @items, selected: @selected_request_item) %> + <%= filter_select(label: "Filter by item", scope: :by_request_item_id, collection: @requests_info.items, selected: @requests_info.selected_request_item) %>
    <% end %> <% if @requests_info.partners.present? %>
    - <%= filter_select(scope: :by_partner, collection: @partners, selected: @selected_partner) %> + <%= filter_select(scope: :by_partner, collection: @requests_info.partners, selected: @requests_info.selected_partner) %>
    <% end %>
    - <%= filter_select(scope: :by_request_type, collection: @requests_info.request_types, key: :last, value: :first, selected: @selected_request_type) %> + <%= filter_select(scope: :by_request_type, collection: @requests_info.request_types, key: :last, value: :first, selected: @requests_info.selected_request_type) %>
    - <%= filter_select(scope: :by_status, collection: @requests_info.statuses, key: :last, value: :first, selected: @selected_status) %> + <%= filter_select(scope: :by_status, collection: @requests_info.statuses, key: :last, value: :first, selected: @requests_info.selected_status) %>
    <%= label_tag "Date Range" %> From 7664d93d2e8873678956d27c91fc797f891ed497 Mon Sep 17 00:00:00 2001 From: Stefanni Brasil Date: Mon, 11 May 2026 17:42:25 -0600 Subject: [PATCH 7/7] linter --- app/controllers/requests_controller.rb | 2 +- app/models/view/request_info.rb | 1 - spec/models/view/request_info_spec.rb | 6 +++--- spec/models/view/requests_spec.rb | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/app/controllers/requests_controller.rb b/app/controllers/requests_controller.rb index f0d625c7af..bf89ccd067 100644 --- a/app/controllers/requests_controller.rb +++ b/app/controllers/requests_controller.rb @@ -12,7 +12,7 @@ def index end def show - @request_info = View::RequestInfo.from_params(params:, organization: current_organization) + @request_info = View::RequestInfo.from_params(params:, organization: current_organization) end # Clicking the "New Distribution" button will set the the request to started diff --git a/app/models/view/request_info.rb b/app/models/view/request_info.rb index 8b4a4b3bd5..9e325e232a 100644 --- a/app/models/view/request_info.rb +++ b/app/models/view/request_info.rb @@ -2,7 +2,6 @@ module View RequestInfo = Data.define( :request ) do - class << self def from_params(params:, organization:) request = organization.requests.find(params[:id]) diff --git a/spec/models/view/request_info_spec.rb b/spec/models/view/request_info_spec.rb index ea207260cf..fd8a64706b 100644 --- a/spec/models/view/request_info_spec.rb +++ b/spec/models/view/request_info_spec.rb @@ -35,7 +35,7 @@ describe "#custom_units" do context "when there are request units for an item request" do - context "when enable_packs is disabled" do + context "when enable_packs is disabled" do it "returns false" do organization = build(:organization) item = build(:item, name: "First item") @@ -45,7 +45,7 @@ :with_item_requests, organization:, request_items: [ - {item_id: item.id, quantity: '559', request_unit: 'flat'} + {item_id: item.id, quantity: "559", request_unit: "flat"} ] ) @@ -67,7 +67,7 @@ :with_item_requests, organization:, request_items: [ - {item_id: item.id, quantity: '559', request_unit: 'flat'}, + {item_id: item.id, quantity: "559", request_unit: "flat"} ] ) request = View::RequestInfo.from_params(params: {id: request.id}, organization:) diff --git a/spec/models/view/requests_spec.rb b/spec/models/view/requests_spec.rb index 40794a3d17..855af78a0b 100644 --- a/spec/models/view/requests_spec.rb +++ b/spec/models/view/requests_spec.rb @@ -16,7 +16,7 @@ it "returns the calculated product total items" do organization = build(:organization) build(:request, :pending, organization:) - total_items_service_double = instance_double(RequestsTotalItemsService, calculate: {"Diaper" => 10}) + total_items_service_double = instance_double(RequestsTotalItemsService, calculate: {"Diaper" => 10}) allow(RequestsTotalItemsService).to receive(:new).with(requests: organization.requests).and_return(total_items_service_double) requests = View::Requests.from_params(params: {}, organization:, helpers:)