Skip to content

Commit 8ebaa94

Browse files
committed
Rename current local to target
1 parent 0a517de commit 8ebaa94

File tree

4 files changed

+24
-31
lines changed

4 files changed

+24
-31
lines changed

lib/rdoc/generator/darkfish.rb

Lines changed: 20 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -318,10 +318,8 @@ def generate_index
318318

319319
render_template template_file, out_file do |io|
320320
here = binding
321-
# suppress 1.9.3 warning
322321
here.local_variable_set(:asset_rel_prefix, asset_rel_prefix)
323-
# some partials rely on the presence of current variable to render
324-
here.local_variable_set(:current, @main_page)
322+
here.local_variable_set(:target, @main_page)
325323
here
326324
end
327325
rescue => e
@@ -336,7 +334,7 @@ def generate_index
336334
# Generates a class file for +klass+
337335

338336
def generate_class klass, template_file = nil
339-
current = klass
337+
target = klass
340338

341339
template_file ||= @template_dir + 'class.rhtml'
342340

@@ -348,16 +346,15 @@ def generate_class klass, template_file = nil
348346

349347
asset_rel_prefix = rel_prefix + @asset_rel_path
350348

351-
breadcrumb = # used in templates
352-
breadcrumb = generate_nesting_namespaces_breadcrumb(current, rel_prefix)
349+
breadcrumb = generate_nesting_namespaces_breadcrumb(target, rel_prefix)
353350

354351
@title = "#{klass.type} #{klass.full_name} - #{@options.title}"
355352

356353
debug_msg " rendering #{out_file}"
357354
render_template template_file, out_file do |io|
358355
here = binding
359-
# suppress 1.9.3 warning
360356
here.local_variable_set(:asset_rel_prefix, asset_rel_prefix)
357+
here.local_variable_set(:breadcrumb, breadcrumb)
361358
here
362359
end
363360
end
@@ -372,16 +369,16 @@ def generate_class_files
372369
return unless template_file.exist?
373370
debug_msg "Generating class documentation in #{@outputdir}"
374371

375-
current = nil
372+
target = nil
376373

377374
@classes.each do |klass|
378-
current = klass
375+
target = klass
379376

380377
generate_class klass, template_file
381378
end
382379
rescue => e
383380
error = RDoc::Error.new \
384-
"error generating #{current.path}: #{e.message} (#{e.class})"
381+
"error generating #{target.path}: #{e.message} (#{e.class})"
385382
error.set_backtrace e.backtrace
386383

387384
raise error
@@ -404,10 +401,10 @@ def generate_file_files
404401
debug_msg "Generating file documentation in #{@outputdir}"
405402

406403
out_file = nil
407-
current = nil
404+
target = nil
408405

409406
@files.each do |file|
410-
current = file
407+
target = file
411408

412409
if file.text? and page_file.exist? then
413410
generate_page file
@@ -440,9 +437,8 @@ def generate_file_files
440437

441438
render_template template_file, out_file do |io|
442439
here = binding
443-
# suppress 1.9.3 warning
444440
here.local_variable_set(:asset_rel_prefix, asset_rel_prefix)
445-
here.local_variable_set(:current, current)
441+
here.local_variable_set(:target, target)
446442
here
447443
end
448444
end
@@ -466,16 +462,15 @@ def generate_page file
466462
search_index_rel_prefix = rel_prefix
467463
search_index_rel_prefix += @asset_rel_path if @file_output
468464

469-
current = file
465+
target = file
470466
asset_rel_prefix = rel_prefix + @asset_rel_path
471467

472468
@title = "#{file.page_name} - #{@options.title}"
473469

474470
debug_msg " rendering #{out_file}"
475471
render_template template_file, out_file do |io|
476472
here = binding
477-
# suppress 1.9.3 warning
478-
here.local_variable_set(:current, current)
473+
here.local_variable_set(:target, target)
479474
here.local_variable_set(:asset_rel_prefix, asset_rel_prefix)
480475
here
481476
end
@@ -500,7 +495,6 @@ def generate_servlet_not_found message
500495

501496
render_template template_file do |io|
502497
here = binding
503-
# suppress 1.9.3 warning
504498
here.local_variable_set(:asset_rel_prefix, asset_rel_prefix)
505499
here
506500
end
@@ -557,7 +551,6 @@ def generate_table_of_contents
557551

558552
render_template template_file, out_file do |io|
559553
here = binding
560-
# suppress 1.9.3 warning
561554
here.local_variable_set(:asset_rel_prefix, asset_rel_prefix)
562555
here
563556
end
@@ -738,15 +731,15 @@ def excerpt(comment)
738731
extracted_text[0...150].gsub(/\n/, " ").squeeze(" ")
739732
end
740733

741-
def generate_table_from_the_current_object(current)
742-
return '' if current.nil?
734+
def generate_table_from_target(target)
735+
return '' if target.nil?
743736
comment =
744-
if current.respond_to? :comment_location then
745-
current.comment_location
737+
if target.respond_to? :comment_location then
738+
target.comment_location
746739
else
747-
current.comment
740+
target.comment
748741
end
749-
current.parse(comment).table_of_contents.dup
742+
target.parse(comment).table_of_contents.dup
750743
end
751744

752745
def generate_ancestor_list(ancestors, klass)
@@ -813,10 +806,10 @@ def generate_sidebar_link(name, path, rel_prefix)
813806
%(<a href="#{rel_prefix}/#{path}">#{name}</a>)
814807
end
815808

816-
def generate_pages_index_content(page_files, rel_prefix, current)
809+
def generate_pages_index_content(page_files, rel_prefix, target)
817810
return '' if page_files.empty?
818811

819-
dir = current&.full_name&.[](/\A[^\/]+(?=\/)/) || current&.page_name
812+
dir = target&.full_name&.[](/\A[^\/]+(?=\/)/) || target&.page_name
820813
grouped_files = page_files.group_by { |f| f.full_name[/\A[^\/]+(?=\/)/] || f.page_name }
821814

822815
traverse_tree(grouped_files) do |name, files|

lib/rdoc/generator/template/darkfish/_sidebar_pages.rhtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
<div id="fileindex-section" class="nav-section">
33
<h3>Pages</h3>
44

5-
<%= generate_pages_index_content(@page_files, rel_prefix, current) %>
5+
<%= generate_pages_index_content(@page_files, rel_prefix, target) %>
66
</div>
77
<%- end -%>

lib/rdoc/generator/template/darkfish/_sidebar_table_of_contents.rhtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
<%- table = generate_table_from_the_current_object(current) -%>
1+
<%- table = generate_table_from_target(target) -%>
22
<%- if table.length > 1 %>
33
<div class="nav-section">
44
<h3>Table of Contents</h3>
55

66
<%- display_link = proc do |heading| -%>
7-
<a href="#<%= heading.label current %>"><%= heading.plain_html %></a>
7+
<a href="#<%= heading.label target %>"><%= heading.plain_html %></a>
88
<%- end -%>
99

1010
<%- list_siblings = proc do -%>

lib/rdoc/generator/template/darkfish/index.rhtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<%= render '_sidebar_search.rhtml' %>
88
</div>
99

10-
<%= render '_sidebar_table_of_contents.rhtml' if defined?(current) %>
10+
<%= render '_sidebar_table_of_contents.rhtml' %>
1111
<%= render '_sidebar_pages.rhtml' %>
1212
<%= render '_sidebar_classes.rhtml' %>
1313

0 commit comments

Comments
 (0)