ossl.c: implement OpenSSL::OpenSSLError#detailed_message #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhenium
force-pushed
the
ky/err-extras
branch
from
4aff47d to
b70d4c1
Compare
An OpenSSL function sometimes puts more than one error entry into the
thread-local error queue. We currently use the last, the highest level
entry for generating the exception message. The rest is silently
dropped unless OpenSSL.debug is set to true, which makes it print to
rb_warn().
Capture all current OpenSSL error queue contents into
OpenSSL::OpenSSLError#errors in ossl_make_error(), and extend
OpenSSL::OpenSSLError#detailed_message to include the information.
An example:
$ ruby -Ilib -ropenssl -e'OpenSSL::X509::ExtensionFactory.new.create_ext("a", "b")'
-e:1:in 'OpenSSL::X509::ExtensionFactory#create_ext': a = b: error in extension (name=a, value=b) (OpenSSL::X509::ExtensionError)
OpenSSL error queue reported 2 errors:
error:11000082:X509 V3 routines:do_ext_nconf:unknown extension name
error:11000080:X509 V3 routines:X509V3_EXT_nconf_int:error in extension (name=a, value=b)
from -e:1:in '<main>'
rhenium
force-pushed
the
ky/err-extras
branch
from
b70d4c1 to
5d5d8a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An OpenSSL function sometimes puts more than one error entry into the thread-local error queue. We currently use the last, the highest level entry for generating the exception message. The rest is silently dropped unless
OpenSSL.debugis set totrue, which makes it print torb_warn().Capture all current OpenSSL error queue contents into
OpenSSL::OpenSSLError#errorsinossl_make_error(), and extendOpenSSL::OpenSSLError#detailed_messageto include the information.An example:
Closes #312.