Commit f004977
committed
♻️ SASL DIGEST-MD5: inherit, props, move, document
* 🚚 Move to sasl directory and SASL namespace.
* 🗑️ Deprecate original constant name.
* ♻️ Inherit from Authenticator base class.
* ♻️ Refactor to the style used in the new ScramAuthenticator.
Yes, DIGEST-MD5 is deprecated! But that also means that it is lower
risk as a test-bed for refactoring a more complicated challenge/response
SASL mechanism, and for developing a reasonable SASL::Authenticator base
class. I improved it in several ways:
* 🔒 Use SecureRandom for cnonce (not Time.now + insecure PRNG!)
* ✨ Default qop=auth (as in RFC)
* ✨ User can configure realm, host, service_name, service.
* This allows a correct "digest-uri" for non-IMAP clients.
* ✨ Enforce requirements for sparam keys (required and no-multiples).
However... it's still deprecated, so maybe don't use unless you need to!1 parent 0ca5152 commit f004977
File tree
4 files changed
+415
-119
lines changed- lib/net/imap
- authenticators
- sasl
- test/net/imap
4 files changed
+415
-119
lines changedThis file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| 68 | + | |
| 69 | + | |
68 | 70 | | |
69 | 71 | | |
70 | 72 | | |
71 | 73 | | |
72 | 74 | | |
73 | 75 | | |
74 | 76 | | |
75 | | - | |
| 77 | + | |
76 | 78 | | |
77 | 79 | | |
78 | 80 | | |
| |||
105 | 107 | | |
106 | 108 | | |
107 | 109 | | |
108 | | - | |
| |||
0 commit comments