From 968d0e8576ef356bcbf1f213ae76d2a4810e25fd Mon Sep 17 00:00:00 2001 From: Ian Murray Date: Thu, 30 Oct 2025 09:16:08 +0100 Subject: [PATCH 1/2] fix checkbox contrast in dark mode Fixes #320. The contrast for the "check" and the background in dark mode was not enough, making it seem like the checkbox was uncheckable. --- lib/ruby_ui/checkbox/checkbox.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ruby_ui/checkbox/checkbox.rb b/lib/ruby_ui/checkbox/checkbox.rb index 3cf579d3..3a985a19 100644 --- a/lib/ruby_ui/checkbox/checkbox.rb +++ b/lib/ruby_ui/checkbox/checkbox.rb @@ -19,7 +19,7 @@ def default_attrs class: [ "peer h-4 w-4 shrink-0 rounded-sm border border-primary ring-offset-background accent-primary", "disabled:cursor-not-allowed disabled:opacity-50", - "checked:bg-primary checked:text-primary-foreground", + "checked:bg-primary checked:text-primary-foreground dark:checked:bg-secondary", "aria-disabled:cursor-not-allowed aria-disabled:opacity-50 aria-disabled:pointer-events-none", "focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2" ] From 51bce622c52ba47d52dd23d479f8f330ca761ab0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Djalma=20Ara=C3=BAjo?= Date: Wed, 19 Nov 2025 12:43:10 -0300 Subject: [PATCH 2/2] Fix checkbox and radio button checked dark mode styles --- lib/ruby_ui/checkbox/checkbox.rb | 4 ++-- lib/ruby_ui/radio_button/radio_button.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ruby_ui/checkbox/checkbox.rb b/lib/ruby_ui/checkbox/checkbox.rb index 3a985a19..23ce0558 100644 --- a/lib/ruby_ui/checkbox/checkbox.rb +++ b/lib/ruby_ui/checkbox/checkbox.rb @@ -17,9 +17,9 @@ def default_attrs action: "change->ruby-ui--checkbox-group#onChange change->ruby-ui--form-field#onInput invalid->ruby-ui--form-field#onInvalid" }, class: [ - "peer h-4 w-4 shrink-0 rounded-sm border border-primary ring-offset-background accent-primary", + "peer h-4 w-4 shrink-0 rounded-sm border-input ring-offset-background accent-primary", "disabled:cursor-not-allowed disabled:opacity-50", - "checked:bg-primary checked:text-primary-foreground dark:checked:bg-secondary", + "checked:bg-primary checked:text-primary-foreground dark:checked:bg-secondary checked:text-primary checked:border-primary", "aria-disabled:cursor-not-allowed aria-disabled:opacity-50 aria-disabled:pointer-events-none", "focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2" ] diff --git a/lib/ruby_ui/radio_button/radio_button.rb b/lib/ruby_ui/radio_button/radio_button.rb index b0e0d9e1..870341a2 100644 --- a/lib/ruby_ui/radio_button/radio_button.rb +++ b/lib/ruby_ui/radio_button/radio_button.rb @@ -18,7 +18,7 @@ def default_attrs class: [ "h-4 w-4 p-0 border-primary rounded-full flex-none", "disabled:cursor-not-allowed disabled:opacity-50", - "checked:bg-primary checked:text-primary-foreground", + "checked:bg-primary checked:text-primary-foreground dark:checked:bg-secondary checked:text-primary checked:border-primary", "aria-disabled:cursor-not-allowed aria-disabled:opacity-50 aria-disabled:pointer-events-none" ] }