From 109e339ac5d803c6745fe84c98ee40d2b99ecad6 Mon Sep 17 00:00:00 2001 From: Karine Vieira Date: Mon, 17 Feb 2025 10:39:33 -0300 Subject: [PATCH 1/2] Upgrade phlex version --- Gemfile.lock | 4 ++-- ruby_ui.gemspec | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 0c0822af..fc479adc 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -16,7 +16,7 @@ GEM parser (3.3.6.0) ast (~> 2.4.1) racc - phlex (2.0.0.beta2) + phlex (2.0.2) racc (1.8.1) rainbow (3.1.1) rake (13.2.1) @@ -60,7 +60,7 @@ PLATFORMS DEPENDENCIES minitest (~> 5.0) - phlex (>= 2.0.0.beta2) + phlex (>= 2.0.2) rake (~> 13.0) rouge (~> 4.2.0) ruby_ui! diff --git a/ruby_ui.gemspec b/ruby_ui.gemspec index c18524a2..bf7213c7 100644 --- a/ruby_ui.gemspec +++ b/ruby_ui.gemspec @@ -15,7 +15,7 @@ Gem::Specification.new do |s| s.required_ruby_version = ">= 3.3.1" - s.add_development_dependency "phlex", ">= 2.0.0.beta2" + s.add_development_dependency "phlex", ">= 2.0.2" s.add_development_dependency "rouge", "~> 4.2.0" s.add_development_dependency "tailwind_merge", "~> 0.12" s.add_development_dependency "rake", "~> 13.0" From 7bf087c620a3724b487d62c9d60a9f5490d19c50 Mon Sep 17 00:00:00 2001 From: Karine Vieira Date: Mon, 17 Feb 2025 11:28:53 -0300 Subject: [PATCH 2/2] refactor: Remove view_context MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With the upgrade, view_context is only required in Rails applications. Since our use case doesn’t require Rails-specific view helpers, we no longer need to pass view_context. --- test/test_helper.rb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/test/test_helper.rb b/test/test_helper.rb index fce11baf..7a5f8fc3 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -19,14 +19,12 @@ module RubyUI class ComponentTest < Minitest::Test def render(component, &) - component.call(view_context:, &) + component.call(&) end def phlex(&) render Phlex::HTML.new, & end - - def view_context = nil end # this is a tracepoint that will output the path of all files loaded that contain the string "phlex"