Remove API token requirement from Danger workflow #2632
+148
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numbata
force-pushed
the
fix_danger_workflow
branch
2 times, most recently
from
d2c8786 to
01e0ede
Compare
Use secure two-workflow pattern from dblock's blog post: - First workflow runs on pull_request, executes danger dry_run without write permissions, uploads JSON report as artifact - Second workflow runs on workflow_run after first completes, downloads artifact and posts PR comment with write access This is secure because untrusted fork code never has access to write permissions. The comment workflow runs trusted code from the base branch. Inlined Dangerfile checks from ruby-grape-danger to avoid plugins that require GitHub API methods not available in dry_run mode.
numbata
force-pushed
the
fix_danger_workflow
branch
from
360835e to
f7113a2
Compare
Apply Style/IfUnlessModifier and Performance/RegexpMatch fixes. Disable Style/SignalException for Danger's `fail` DSL method.
For fork PRs, github.event.workflow_run.pull_requests is always empty due to GitHub security restrictions. Include PR number in the danger_report.json artifact instead.
numbata
force-pushed
the
fix_danger_workflow
branch
from
d7dc3d5 to
eb222e4
Compare
numbata
commented
Dec 7, 2025
| # frozen_string_literal: true | ||
|
|
||
| danger.import_dangerfile(gem: 'ruby-grape-danger') | ||
| # Inline checks from ruby-grape-danger (avoids plugins requiring GitHub API token) |
Contributor
Author
There was a problem hiding this comment.
All this, ofc, should be moved to the https://github.com/ruby-grape/danger/blob/master/Dangerfile
numbata
commented
Dec 7, 2025
| message('We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!', sticky: false) if !has_app_changes && has_spec_changes | ||
|
|
||
| # Simplified changelog check (replaces danger-changelog plugin which requires github.* methods) | ||
| # Note: toc.check! from danger-toc plugin removed (not essential for CI) |
Contributor
Author
There was a problem hiding this comment.
This is aligned with:
https://github.com/ruby-grape/danger/pull/14/files
- Add explicit PR event types (opened, synchronize, reopened) - Set artifact retention to 1 day - Fix regex patterns with word boundaries to avoid false positives
numbata
force-pushed
the
fix_danger_workflow
branch
from
8228003 to
8c59d3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to tokenless execution using with GitHub Actions annotations for inline feedback. This eliminates the need for the grape-bot token while still providing PR feedback via workflow annotations.
Changes: