Terminate all children on parent termination

Author: pitr-ch

lib/concurrent/actress/core.rb

@@ -109,9 +109,14 @@ def terminated?
         @terminated.set?
       end
 
-      # Terminates the actor, any Envelope received after termination is rejected
+      # Terminates the actor. Any Envelope received after termination is rejected.
+      # Terminates all its children, does not wait until they are terminated.
       def terminate!
         guard!
+        @children.each do |ch|
+          ch.send(:core).tap { |core| core.send(:schedule_execution) { core.terminate! } }
+        end
+
         @terminated.set
 
         @parent_core.remove_child reference if @parent_core
@@ -120,7 +125,6 @@ def terminate!
           log DEBUG, "rejected #{envelope.message} from #{envelope.sender_path}"
         end
         @mailbox.clear
-        # TODO terminate all children
 
         nil
       end

spec/concurrent/actress_spec.rb

@@ -163,6 +163,30 @@ def assert condition
         end
       end
 
+      describe 'termination' do
+        subject do
+          AdHoc.spawn(:parent) do
+            child = AdHoc.spawn(:child) { -> v { v } }
+            -> v do
+              if v == :terminate
+                terminate!
+              else
+                child
+              end
+            end
+          end
+        end
+
+        it 'terminates with all its children' do
+          child = subject.ask! :child
+          subject.terminated?.should be_false
+          subject.ask(:terminate).wait
+          subject.terminated?.should be_true
+          child.terminated.wait
+          child.terminated?.should be_true
+        end
+      end
+
     end
   end
 end