Fix ruby warnings

Author: pitr-ch

lib-edge/concurrent/edge/erlang_actor.rb

@@ -529,7 +529,7 @@ module FunctionShortcuts
       # Optionally included shortcut method for {Functions#spawn_actor}
       # @return [Pid]
       def spawn(*args, &body)
-        spawn_actor *args, &body
+        spawn_actor(*args, &body)
       end
 
       # Optionally included shortcut method for {Functions#terminate_actor}

spec/concurrent/agent_spec.rb

@@ -75,9 +75,8 @@ module Concurrent
       end
 
       specify 'upon validation the new value will be set to the block return value' do
-        actual    = nil
         expected  = 42
-        validator = ->(new_value) { true }
+        validator = ->(_new_value) { true }
         subject   = Agent.new(0, validator: validator)
         subject.send_via(immediate) { expected }
         expect(subject.value).to eq expected
@@ -323,8 +322,6 @@ def update(time, old_value, new_value)
         end
 
         it 'does not block further action processing' do
-          expected = 42
-          actual   = nil
           subject  = Agent.new(0, error_mode: :continue)
           subject.send_via(immediate) { raise StandardError }
           subject.send_via(immediate) { 42 }

spec/concurrent/cancellation_spec.rb

@@ -3,7 +3,7 @@
     specify 'basic' do
       cancellation, origin = Concurrent::Cancellation.new
       expect(cancellation.origin).to eq origin
-      expect(cancellation.to_s).to match /Cancellation.*pending/
+      expect(cancellation.to_s).to match(/Cancellation.*pending/)
 
       futures1 = ::Array.new(2) do
         Concurrent::Promises.future(cancellation) do |c|
@@ -20,7 +20,7 @@
 
       sleep 0.01
       origin.resolve
-      expect(cancellation.to_s).to match /Cancellation.*canceled/
+      expect(cancellation.to_s).to match(/Cancellation.*canceled/)
 
       futures1.each do |future|
         expect(future.value!).to eq :done

spec/concurrent/channel/tick_spec.rb

@@ -18,8 +18,8 @@ class Channel
 
       specify '#utc returns a Time object in UTC' do
         t = subject.utc
-        expect(subject.utc).to be_a Time
-        expect(subject.utc.zone).to eq 'UTC'
+        expect(t).to be_a Time
+        expect(t.zone).to eq 'UTC'
       end
 
       specify '#epoch returns the UTC time as epoch seconds' do
@@ -45,7 +45,6 @@ class Channel
         end
 
         it 'correctly compares to a Time' do
-          present = Time.now
           past = Time.now - 42*60*60
           future = Time.now + 42*60*60
 

spec/concurrent/edge/erlang_actor_spec.rb

@@ -552,7 +552,7 @@
               expect(trapped_exit.from).to eq b
               expect(trapped_exit.reason).to eq b.terminated.reason
               expect(trapped_exit.reason).to be_a ArgumentError
-              expect(trapped_exit.reason.message).to match /uncaught throw :uncaught/
+              expect(trapped_exit.reason.message).to match(/uncaught throw :uncaught/)
             end
           end
 

spec/concurrent/executor/safe_task_executor_spec.rb

@@ -10,17 +10,17 @@ module Concurrent
         subject { SafeTaskExecutor.new(task) }
 
         it 'should return success' do
-          success, value, reason = subject.execute
+          success, _value, _reason = subject.execute
           expect(success).to be_truthy
         end
 
         it 'should return task value' do
-          success, value, reason = subject.execute
+          _success, value, _reason = subject.execute
           expect(value).to eq 42
         end
 
         it 'should return a nil reason' do
-          success, value, reason = subject.execute
+          _success, _value, reason = subject.execute
           expect(reason).to be_nil
         end
 
@@ -43,17 +43,17 @@ module Concurrent
         subject { SafeTaskExecutor.new(task) }
 
         it 'should return false success' do
-          success, value, reason = subject.execute
+          success, _value, _reason = subject.execute
           expect(success).to be_falsey
         end
 
         it 'should return a nil value' do
-          success, value, reason = subject.execute
+          _success, value, _reason = subject.execute
           expect(value).to be_nil
         end
 
         it 'should return the reason' do
-          success, value, reason = subject.execute
+          _success, _value, reason = subject.execute
           expect(reason).to be_a(StandardError)
           expect(reason.message).to eq 'an error'
         end

spec/concurrent/maybe_spec.rb

@@ -21,7 +21,7 @@ module Concurrent
         it 'passes all arguments to the block' do
           expected = [1, 2, 3]
           actual = nil
-          maybe = Maybe.from(*expected) do |*args|
+          Maybe.from(*expected) do |*args|
             actual = args
           end
           expect(actual).to eq expected

spec/concurrent/mvar_spec.rb

@@ -55,7 +55,7 @@ def dereferenceable_subject(value, opts = {})
       it 'waits for another thread to #put' do
         m = MVar.new
 
-        putter = in_thread {
+        in_thread {
           sleep(0.1)
           m.put 14
         }
@@ -115,7 +115,7 @@ def dereferenceable_subject(value, opts = {})
       it 'waits for another thread to #take' do
         m = MVar.new(14)
 
-        putter = in_thread {
+        in_thread {
           sleep(0.1)
           m.take
         }
@@ -184,7 +184,7 @@ def dereferenceable_subject(value, opts = {})
       it 'waits for another thread to #put' do
         m = MVar.new
 
-        putter = in_thread {
+        in_thread {
           sleep(0.1)
           m.put 14
         }
@@ -198,7 +198,7 @@ def dereferenceable_subject(value, opts = {})
         # #modify conceptually does #take and #put - but it should be atomic.
         # Check that another #put can't sneak it during the #modify.
 
-        modifier = in_thread {
+        in_thread {
           m.modify do |v|
             sleep(0.5)
             1

spec/concurrent/scheduled_task_spec.rb

@@ -56,7 +56,6 @@ def trigger_observable(observable)
       it 'accepts a number of seconds (from now) as the schedule time' do
         expected = 60
         Timecop.freeze do
-          now = Time.now
           task = ScheduledTask.new(expected){ nil }.execute
           expect(task.initial_delay).to be_within(0.1).of(expected)
         end

spec/concurrent/throttle_spec.rb

@@ -41,7 +41,7 @@
 
     specify '#to_s' do
       throttle = Concurrent::Throttle.new 2
-      expect(throttle.to_s).to match /Throttle.*available 2 of 2/
+      expect(throttle.to_s).to match(/Throttle.*available 2 of 2/)
     end
 
     specify '#on' do
@@ -76,8 +76,8 @@
       ).value!
       expect(result.all? { |v| v <= limit }).to be_truthy, result.to_s
 
-      result = Array.new(20) do |i|
-        Thread.new(i) { |i| throttle.acquire { testing.call i } }
+      result = Array.new(20) do |i1|
+        Thread.new(i1) { |i2| throttle.acquire { testing.call i2 } }
       end.map(&:value)
       expect(result.all? { |v| v <= limit }).to be_truthy, result.to_s