Skip to content

request: annotations/labels + dd resource profile name to launcher job template data #845

@jjjermiah

Description

@jjjermiah

this request is in 2 parts:

1. Resource Profile tags/annotations

currently the launcher resolves a resource profile (e.g. standard/highmemory in our case) into raw resourceLimits and placementConstraints before passing data to job.tpl.

  • by the time the template executes, the profile name is gone, only the CPU/memory values remain.

this makes it impossible to label pods with the profile name

  • I currently reverse engineer custom labels by reverse mapping to exact resource numbers in a custom job.tpl

would it be possible to expose the profile name in the .Job object or as a tag in .Job.tags? Something like:

  • A .Job.resourceProfile field, or
  • A tag like pwb-resource-profile:1-standard-1

2. Helm chart options to add some of the tags as labels

I currently have some custom mapping in the job.tpl that extracts the Jobs.tags and adds it as label, such as

  • workbench/username
  • workbench/ide-type
  • workbench/resource-profile (from the reverse engineering above)
  • workbench/type (job / interactive)
  • etc..

this helps us in many ways including via ksm-allow-lists for prometheus, easy cli monitoring via kubectl filters.

It would help if there was some way to do some sort of variable mapping to labels or something so I dont have to maintain custom .tpl stuff and can rely on the provided ones

thank you!

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions