Skip to content

Commit cd32b5c

Browse files
andimarekclaude
andcommitted
Remove redundant checks in assertValidName, mark param @nullable
- Mark assertValidName parameter as @nullable since callers may pass null - Keep null check in assertValidName (required for @nullable contract) - Remove redundant empty check that was duplicated in isValidName - Use String.valueOf() for null-safe error message formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 14a31e4 commit cd32b5c

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

src/main/java/graphql/Assert.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,11 +231,11 @@ public static void assertFalse(boolean condition, String msgFmt, Object arg1, Ob
231231
*
232232
* @return the name if valid, or AssertException if invalid.
233233
*/
234-
public static String assertValidName(String name) {
235-
if (name != null && !name.isEmpty() && isValidName(name)) {
234+
public static String assertValidName(@Nullable String name) {
235+
if (name != null && isValidName(name)) {
236236
return name;
237237
}
238-
return throwAssert(invalidNameErrorMessage, name);
238+
return throwAssert(invalidNameErrorMessage, String.valueOf(name));
239239
}
240240

241241
/**

0 commit comments

Comments
 (0)