Skip to content

Commit 8b844e8

Browse files
authored
fix: move open to dev dependencies (#133)
1 parent 6f76504 commit 8b844e8

3 files changed

Lines changed: 46 additions & 44 deletions

File tree

package.json

Lines changed: 40 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
{
22
"name": "@rspack/dev-server",
33
"version": "2.0.0-beta.1",
4-
"type": "module",
5-
"license": "MIT",
64
"description": "Development server for rspack",
7-
"types": "./dist/index.d.ts",
8-
"publishConfig": {
9-
"access": "public",
10-
"registry": "https://registry.npmjs.org/"
5+
"homepage": "https://rspack.rs",
6+
"bugs": "https://github.com/rstackjs/rspack-dev-server/issues",
7+
"repository": {
8+
"type": "git",
9+
"url": "https://github.com/rstackjs/rspack-dev-server"
1110
},
11+
"license": "MIT",
12+
"type": "module",
1213
"exports": {
1314
".": "./dist/index.js",
1415
"./getPort": "./getPort.js",
@@ -18,16 +19,21 @@
1819
"./client/*.js": "./client/*.js",
1920
"./package.json": "./package.json"
2021
},
22+
"types": "./dist/index.d.ts",
23+
"files": [
24+
"dist",
25+
"client"
26+
],
2127
"scripts": {
2228
"build": "rslib",
29+
"bump": "npx bumpp",
2330
"dev": "rslib -w",
31+
"format": "prettier --write .",
2432
"lint": "biome check .",
2533
"lint:write": "biome check . --write",
26-
"format": "prettier --write .",
2734
"prettier:ci": "prettier --check .",
28-
"test:install": "cross-env ./node_modules/.bin/puppeteer browsers install chrome",
2935
"test": "pnpm run test:install && pnpm run build && rstest",
30-
"bump": "npx bumpp"
36+
"test:install": "cross-env ./node_modules/.bin/puppeteer browsers install chrome"
3137
},
3238
"simple-git-hooks": {
3339
"pre-commit": "npx nano-staged"
@@ -41,19 +47,22 @@
4147
"biome lint --write --no-errors-on-unmatched"
4248
]
4349
},
44-
"files": [
45-
"dist",
46-
"client"
47-
],
48-
"engines": {
49-
"node": "^20.19.0 || >=22.12.0"
50-
},
51-
"packageManager": "pnpm@10.30.3",
52-
"homepage": "https://rspack.rs",
53-
"bugs": "https://github.com/rstackjs/rspack-dev-server/issues",
54-
"repository": {
55-
"type": "git",
56-
"url": "https://github.com/rstackjs/rspack-dev-server"
50+
"dependencies": {
51+
"@types/connect-history-api-fallback": "^1.5.4",
52+
"@types/serve-index": "^1.9.4",
53+
"@types/serve-static": "^2.2.0",
54+
"@types/ws": "^8.18.1",
55+
"chokidar": "^3.6.0",
56+
"compression": "^1.8.1",
57+
"connect-history-api-fallback": "^2.0.0",
58+
"express": "^5.2.1",
59+
"http-proxy-middleware": "^3.0.5",
60+
"ipaddr.js": "^2.3.0",
61+
"launch-editor": "^2.13.1",
62+
"p-retry": "^7.1.1",
63+
"serve-index": "^1.9.2",
64+
"webpack-dev-middleware": "^7.4.5",
65+
"ws": "^8.19.0"
5766
},
5867
"devDependencies": {
5968
"@biomejs/biome": "^1.9.4",
@@ -75,6 +84,7 @@
7584
"hono": "^4.12.3",
7685
"http-proxy": "^1.18.1",
7786
"nano-staged": "^0.9.0",
87+
"open": "^11.0.0",
7888
"prettier": "3.8.1",
7989
"puppeteer": "^24.37.5",
8090
"react-refresh": "0.18.0",
@@ -85,24 +95,6 @@
8595
"typescript": "^5.9.3",
8696
"webpack-dev-middleware": "^7.4.5"
8797
},
88-
"dependencies": {
89-
"@types/connect-history-api-fallback": "^1.5.4",
90-
"@types/serve-index": "^1.9.4",
91-
"@types/serve-static": "^2.2.0",
92-
"@types/ws": "^8.18.1",
93-
"chokidar": "^3.6.0",
94-
"compression": "^1.8.1",
95-
"connect-history-api-fallback": "^2.0.0",
96-
"express": "^5.2.1",
97-
"http-proxy-middleware": "^3.0.5",
98-
"ipaddr.js": "^2.3.0",
99-
"launch-editor": "^2.13.1",
100-
"open": "^11.0.0",
101-
"p-retry": "^7.1.1",
102-
"serve-index": "^1.9.2",
103-
"webpack-dev-middleware": "^7.4.5",
104-
"ws": "^8.19.0"
105-
},
10698
"peerDependencies": {
10799
"@rspack/core": "^2.0.0-0",
108100
"selfsigned": "^5.0.0"
@@ -111,5 +103,13 @@
111103
"selfsigned": {
112104
"optional": true
113105
}
106+
},
107+
"packageManager": "pnpm@10.30.3",
108+
"engines": {
109+
"node": "^20.19.0 || >=22.12.0"
110+
},
111+
"publishConfig": {
112+
"access": "public",
113+
"registry": "https://registry.npmjs.org/"
114114
}
115115
}

pnpm-lock.yaml

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/server.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2182,7 +2182,9 @@ class Server<
21822182
}
21832183

21842184
async openBrowser(defaultOpenTarget: string): Promise<void> {
2185-
const open = (await import('open')).default;
2185+
const { default: open } = await import(
2186+
/* webpackChunkName: "open" */ 'open'
2187+
);
21862188

21872189
Promise.all(
21882190
(this.options.open as NormalizedOpen[]).map((item) => {

0 commit comments

Comments
 (0)