Future<T>::then Future<T>::then(not-try-task) -> Future<T>::thenValue(task).

Summary:
Overall plan to modify Future<T>::then to be r-value qualified and use Future<T>::thenTry or Future<T>::thenValue.

The goal is to disambiguate folly::Future and to improve type and lifetime safety of Future and its methods.

Codemod:
 * future<T>.then(callable with operator()(not-a-try)) to future<T>.thenValue(callable with operator()(not-a-try)).
 * future<T>.then(callable with operator()()) to future<T>.thenValue(callable with operator()(auto&&)).
 * future<T>.then(callable with operator()(auto)) to future<T>.thenValue(callable with operator()(auto)).

Reviewed By: yfeldblum

Differential Revision: D9520816

fbshipit-source-id: f0438cfe489ba676d80a5ca0dae58c0501d040c9

Author: LeeHowes

rsocket/RSocketClient.cpp

@@ -75,7 +75,7 @@ folly::Future<folly::Unit> RSocketClient::resume() {
       << "resume";
 
   return connectionFactory_->connect(protocolVersion_, ResumeStatus::RESUMING)
-      .then(
+      .thenValue(
           [this](
               ConnectionFactory::ConnectedDuplexConnection connection) mutable {
             return resumeFromConnection(std::move(connection));