From d7692f9fb34f4d2f97a6fbf90baa0a988f47d367 Mon Sep 17 00:00:00 2001 From: Yasuo Honda Date: Wed, 6 May 2026 00:26:51 +0900 Subject: [PATCH] Drop stale describe_synonym comment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Both lines of the comment above PLSQL::Connection#describe_synonym are no longer true: - "all_synonyms view is quite slow" — measured against Oracle 23ai with a 1500-synonym fixture this method is ~0.43 ms/call, dominated by network round-trip rather than the dictionary-view query. The slow case the comment was written for (oracle-enhanced #2686 saw 29x on private synonyms in a 1000-object schema) doesn't show up at the scales ruby-plsql actually exercises. - "overridden in OCI connection with faster native OCI method" — that override was removed in 4d1f656 (2018, "Remove OCI8#describe_synonym to follow up #153") because the predecessor commit 1daa6ce already deleted its body and made it call super. There is no longer any driver-specific override. The method's name and SQL are self-explanatory; removing both lines without a replacement keeps the file accurate. Co-Authored-By: Claude Opus 4.7 (1M context) --- lib/plsql/connection.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/plsql/connection.rb b/lib/plsql/connection.rb index 2f41190e..2ec71502 100644 --- a/lib/plsql/connection.rb +++ b/lib/plsql/connection.rb @@ -179,8 +179,6 @@ def fetch_hash end end - # all_synonyms view is quite slow therefore - # this implementation is overriden in OCI connection with faster native OCI method def describe_synonym(schema_name, synonym_name) # :nodoc: select_first( "SELECT table_owner, table_name FROM all_synonyms WHERE owner = :owner AND synonym_name = :synonym_name",