Dynamically redefine the image topic

[AndyZe]

I'm interested in programmatically defining the image topic so I can switch between multiple cameras. Please advise if you would welcome a PR to do that, and if you would prefer it to be accomplished via ROS service or a dynamically configurable parameter (or maybe some other way)...

I think I would prefer to do it via ROS service.

[dirk-thomas]

A service sounds like the better idea to me. A PR would certainly be welcome 🙇‍♂️

[gstavrinos]

Which service type would be the preferred one for such functionality?

[AndyZe]

You can check out the PR here: https://github.com/ros-visualization/rqt_image_view/pull/17/files

I did a string request, empty response. Hopefully that works for you, @gstavrinos.

[gstavrinos]

Looking good @AndyZe! Check your PRs for a quick fix. There is still a problem though, described in the commit message.

Cheers,

George

[AndyZe]

Cool, I tested your PR it works well. In my opinion, the other problem that you mentioned (clashing when rosrun-ing multiple instances) is a minor concern. If you wanted multiple, separate image views, why not use image_view? rqt_image_view is specifically intended to run from the GUI, I think.

Thanks!

[gstavrinos]

I hope so. Maybe Dirk or some other ROS master can tell us their opinion on the matter.