Merge pull request Expensify#79286 from margelo/@chrispader/react-compiler-v1-lint-rules

[No QA] React Compiler v1 Rules (latest `eslint-plugin-react-hooks`)

Author: roryabraham

.github/actions/javascript/authorChecklist/index.js

@@ -784,6 +784,7 @@
         "Yema",
         "yourcompany",
         "yourname",
+        "yalc",
         "YYMM",
         "zencdn",
         "Zenefit",

cspell.json

@@ -4,7 +4,6 @@ import expensifyConfig from 'eslint-config-expensify';
 import jsdoc from 'eslint-plugin-jsdoc';
 import lodash from 'eslint-plugin-lodash';
 import react from 'eslint-plugin-react';
-import reactCompiler from 'eslint-plugin-react-compiler';
 import reactNativeA11Y from 'eslint-plugin-react-native-a11y';
 import testingLibrary from 'eslint-plugin-testing-library';
 import youDontNeedLodashUnderscore from 'eslint-plugin-you-dont-need-lodash-underscore';
@@ -180,7 +179,6 @@ const config = defineConfig([
             'react-native-a11y': reactNativeA11Y,
             react,
             'testing-library': testingLibrary,
-            'react-compiler': reactCompiler,
             lodash,
         },
 
@@ -322,7 +320,6 @@ const config = defineConfig([
                     touchables: ['PressableWithoutFeedback', 'PressableWithFeedback'],
                 },
             ],
-            'react-compiler/react-compiler': 'error',
 
             // Disallow usage of certain functions and imports
             'no-restricted-syntax': [
@@ -606,6 +603,7 @@ const config = defineConfig([
         'web/gtm.js',
         '**/.expo/**/*',
         '**/.rock/**/*',
+        '**/.yalc/**/*',
         'src/libs/SearchParser/searchParser.js',
         'src/libs/SearchParser/autocompleteParser.js',
         'help/_scripts/**/*',

eslint.config.mjs

@@ -43,7 +43,7 @@
     "test:debug": "TZ=utc NODE_OPTIONS='--inspect-brk --experimental-vm-modules' jest --runInBand",
     "perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure",
     "typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc",
-    "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=110 --cache --cache-location=node_modules/.cache/eslint --cache-strategy content --concurrency=auto",
+    "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=669 --cache --cache-location=node_modules/.cache/eslint --cache-strategy content --concurrency=auto",
     "lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh",
     "check-lazy-loading": "ts-node scripts/checkLazyLoading.ts",
     "lint-watch": "npx eslint-watch --watch --changed",
@@ -310,12 +310,11 @@
     "dotenv": "^16.0.3",
     "eslint": "^9.36.0",
     "eslint-config-airbnb-typescript": "^18.0.0",
-    "eslint-config-expensify": "2.0.101",
+    "eslint-config-expensify": "2.0.103",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-jest": "^29.0.1",
     "eslint-plugin-jsdoc": "^60.7.0",
     "eslint-plugin-lodash": "^7.4.0",
-    "eslint-plugin-react-compiler": "^19.1.0-rc.2",
     "eslint-plugin-react-native-a11y": "^3.3.0",
     "eslint-plugin-storybook": "^10.1.10",
     "eslint-plugin-testing-library": "^7.11.0",

package-lock.json

@@ -238,7 +238,7 @@ class ReactCompilerHealthcheck {
  * Analyzes git diffs to filter compiler results to only changed lines.
  */
 class DiffAnalyzer {
-    private static readonly ESLINT_LINT_RULES = ['react-compiler/react-compiler', 'react-hooks'] as const;
+    private static readonly ESLINT_LINT_RULES = ['react-hooks'] as const;
 
     /**
      * Filter compiler results to only include errors for lines that were changed in the git diff.

package.json

@@ -13,7 +13,7 @@ const EslintUtils = {
      *
      * @param content - The line content to check
      * @param isFileLevel - Whether to check for file-level disable comments (true) or line-level (false)
-     * @param rules - Array of ESLint rule names to check for (e.g., ['react-compiler/react-compiler', 'react-hooks'])
+     * @param rules - Array of ESLint rule names to check for (e.g., ['react-hooks'])
      * @returns True if the line contains a matching eslint-disable comment
      */
     hasEslintDisableComment(content: string, isFileLevel: boolean, rules: string[]): boolean {

scripts/react-compiler-compliance-check.ts

@@ -313,7 +313,7 @@ function Expensify() {
             }
             linkingChangeListener.current.remove();
         };
-        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps -- we don't want this effect to run again
+        // eslint-disable-next-line react-hooks/exhaustive-deps -- we don't want this effect to run again
     }, [sessionMetadata?.status]);
 
     // This is being done since we want to play sound even when iOS device is on silent mode, to align with other platforms.
@@ -328,7 +328,7 @@ function Expensify() {
         updateLastRoute('');
         Navigation.navigate(lastRoute as Route);
         // Disabling this rule because we only want it to run on the first render.
-        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
+        // eslint-disable-next-line react-hooks/exhaustive-deps
     }, [isNavigationReady]);
 
     useEffect(() => {

scripts/utils/EslintUtils.ts

@@ -12,7 +12,7 @@ function useActionSheetAwareScrollViewRef(ref: Ref<ActionSheetAwareScrollViewHan
             if (typeof ref === 'function') {
                 ref(assignedRef);
             } else if (ref) {
-                // eslint-disable-next-line no-param-reassign, react-compiler/react-compiler
+                // eslint-disable-next-line no-param-reassign
                 ref.current = assignedRef;
             }
 

src/Expensify.tsx

@@ -86,7 +86,6 @@ function useActionSheetKeyboardSpacing(scrollViewAnimatedRef: AnimatedRef<Reanim
             if (lastState === syncLocalWorkletState.get()) {
                 return;
             }
-            // eslint-disable-next-line react-compiler/react-compiler
             syncLocalWorkletState.set(lastState);
 
             if (lastState === KeyboardState.OPEN) {