diff --git a/frontend/src/app/components/dashboard/db-table-view/db-table-widgets/db-table-widgets.component.spec.ts b/frontend/src/app/components/dashboard/db-table-view/db-table-widgets/db-table-widgets.component.spec.ts index 807e90584..4401eceb8 100644 --- a/frontend/src/app/components/dashboard/db-table-view/db-table-widgets/db-table-widgets.component.spec.ts +++ b/frontend/src/app/components/dashboard/db-table-view/db-table-widgets/db-table-widgets.component.spec.ts @@ -158,8 +158,8 @@ describe('DbTableWidgetsComponent', () => { }, { field_name: '', - widget_type: '', - widget_params: '', + widget_type: 'Default', + widget_params: '// No settings required', name: '', description: '' } @@ -173,44 +173,6 @@ describe('DbTableWidgetsComponent', () => { expect(component.fields).toEqual(['user_id', 'last_name', 'email']); }); - it('should set empty string in widget_type if widget does not need another appearance', () => { - component.widgets = [ - { - field_name: 'user_id', - widget_type: 'textarea', - widget_params: '', - name: '', - description: '' - }, - { - field_name: 'user_name', - widget_type: 'Default', - widget_params: '// No settings required', - name: 'name', - description: '' - } - ]; - - component.widgetTypeChange('user_name'); - - expect(component.widgets).toEqual([ - { - field_name: 'user_id', - widget_type: 'textarea', - widget_params: '', - name: '', - description: '' - }, - { - field_name: 'user_name', - widget_type: '', - widget_params: '// No settings required', - name: 'name', - description: '' - } - ]) - }); - xit('should open dialog to confirm deletion of widget', () => { component.fields = ['user_age']; component.widgets = [ diff --git a/frontend/src/app/components/dashboard/db-table-view/db-table-widgets/db-table-widgets.component.ts b/frontend/src/app/components/dashboard/db-table-view/db-table-widgets/db-table-widgets.component.ts index e321ce920..951edc19f 100644 --- a/frontend/src/app/components/dashboard/db-table-view/db-table-widgets/db-table-widgets.component.ts +++ b/frontend/src/app/components/dashboard/db-table-view/db-table-widgets/db-table-widgets.component.ts @@ -306,8 +306,8 @@ export class DbTableWidgetsComponent implements OnInit { addNewWidget() { this.widgets.push({ field_name: '', - widget_type: '', - widget_params: '', + widget_type: 'Default', + widget_params: '// No settings required', name: '', description: '' }); @@ -319,8 +319,6 @@ export class DbTableWidgetsComponent implements OnInit { widgetTypeChange(fieldName) { let currentWidget = this.widgets.find(widget => widget.field_name === fieldName); - - if (currentWidget.widget_type === 'Default') currentWidget.widget_type = ''; currentWidget.widget_params = this.defaultParams[currentWidget.widget_type || 'Default']; this.widgetParamsChange({fieldName: currentWidget.field_name, value: currentWidget.widget_params}); @@ -373,12 +371,20 @@ export class DbTableWidgetsComponent implements OnInit { .subscribe(res => { const currentWidgetTypes = res.map((widget: Widget) => widget.field_name); this.fields = difference(this.fields, currentWidgetTypes); + res.forEach((widget: Widget) => { + if (widget.widget_type === '') widget.widget_type = 'Default'; + }) this.widgets = res; }); } updateWidgets(afterDeleteAll?: boolean) { this.submitting = true; + + this.widgets.forEach(widget => { + if (widget.widget_type === 'Default') widget.widget_type = ''; + }); + this._tables.updateTableWidgets(this.connectionID, this.tableName, this.widgets) .subscribe(() => { this.submitting = false; diff --git a/frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-dialog/saved-filters-dialog.component.html b/frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-dialog/saved-filters-dialog.component.html index f6e373290..843615c44 100644 --- a/frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-dialog/saved-filters-dialog.component.html +++ b/frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-dialog/saved-filters-dialog.component.html @@ -1,13 +1,13 @@
diff --git a/frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-panel.component.html b/frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-panel.component.html index 3aa69fa85..7b307f10b 100644 --- a/frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-panel.component.html +++ b/frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-panel.component.html @@ -8,12 +8,12 @@ angularticsAction="Saved filters: first time setup is clicked" (click)="handleOpenSavedFiltersDialog()">