From 86aa87edf068c7277489d301af52439da74bb89b Mon Sep 17 00:00:00 2001 From: Artem Niehrieiev Date: Thu, 22 May 2025 09:22:30 +0000 Subject: [PATCH] Refactor mailing results handling in CronJobsService to format email results for Slack notifications --- backend/src/entities/cron-jobs/cron-jobs.service.ts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/backend/src/entities/cron-jobs/cron-jobs.service.ts b/backend/src/entities/cron-jobs/cron-jobs.service.ts index 2aab070a2..bead6f63d 100644 --- a/backend/src/entities/cron-jobs/cron-jobs.service.ts +++ b/backend/src/entities/cron-jobs/cron-jobs.service.ts @@ -72,7 +72,9 @@ export class CronJobsService { Constants.EXCEPTIONS_CHANNELS, ); } else { - await this.sendEmailResultsToSlack(mailingResults); + const mailingResultToString = this.sentEmailsToSimpleString(mailingResults); + await slackPostMessage(mailingResultToString, Constants.EXCEPTIONS_CHANNELS); + // await this.sendEmailResultsToSlack(mailingResults); await slackPostMessage( `morning cron finished at ${Constants.CURRENT_TIME_FORMATTED()}`, Constants.EXCEPTIONS_CHANNELS, @@ -134,4 +136,12 @@ export class CronJobsService { await slackPostMessage(message, Constants.EXCEPTIONS_CHANNELS); } } + + private sentEmailsToSimpleString(results: Array): string | null { + const emailsSent = results.map((result) => { + return result.accepted && result.accepted.length > 0 ? result.accepted.join(', ') : '-'; + }); + const emailsSentString = emailsSent.join(', \n'); + return emailsSentString; + } }