Skip to content

fix #821: raise default max_packet_size for multitrack support #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ayoub-glitsh wants to merge 1 commit into from
Closed

fix #821: raise default max_packet_size for multitrack support #833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/internal_modules/roc_audio/packetizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,12 @@ packet::PacketPtr Packetizer::create_packet_() {
}

if (!composer_.prepare(*packet, buffer, payload_size_)) {
roc_log(LogError, "packetizer: can't prepare packet");
roc_log(LogError,
"packetizer: can't prepare packet:"
" packet buffer is too small for the requested payload:"
" payload_size=%lu buffer_capacity=%lu"
" (increase max_packet_size in context config)",
(unsigned long)payload_size_, (unsigned long)buffer.capacity());
return NULL;
}
packet->add_flags(packet::Packet::FlagPrepared);
Expand Down
2 changes: 1 addition & 1 deletion src/internal_modules/roc_node/context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ struct ContextConfig {
size_t max_frame_size;

ContextConfig()
: max_packet_size(2048)
: max_packet_size(16384)
, max_frame_size(4096) {
}
};
Expand Down
Loading