Deprecate callback option.

Author: Robert Pustułka

src/Excel/Manager.php

@@ -320,7 +320,10 @@ public function getReader(File $file, array $options = [])
             }
         }
         if (isset($options['callback'])) {
-            $result = $options['callback']($reader, $file);
+            trigger_error('Option `callback` has been deprecated. Use `readerCallback` instead', E_USER_DEPRECATED);
+        }
+        if (isset($options['readerCallback'])) {
+            $result = $options['readerCallback']($reader, $file);
             if ($result instanceof PHPExcel_Reader_IReader) {
                 $reader = $result;
             }
@@ -357,7 +360,10 @@ public function getWriter(PHPExcel $excel, File $file, array $options = [])
             }
         }
         if (isset($options['callback'])) {
-            $result = $options['callback']($writer, $file);
+            trigger_error('Option `callback` has been deprecated. Use `writerCallback` instead', E_USER_DEPRECATED);
+        }
+        if (isset($options['writerCallback'])) {
+            $result = $options['writerCallback']($writer, $file);
             if ($result instanceof PHPExcel_Writer_IWriter) {
                 $writer = $result;
             }

tests/TestCase/Excel/ManagerTest.php

@@ -111,7 +111,7 @@ public function testGetReaderCallback()
         $file = $this->getFile('test.csv');
 
         $reader = $manager->getReader($file, [
-            'callback' => function ($reader) {
+            'readerCallback' => function ($reader) {
                 $reader->setEnclosure('FOO');
 
                 return $reader;
@@ -163,7 +163,7 @@ public function testGetWriterCallback()
         $file = $this->getFile('test.csv');
 
         $writer = $manager->getWriter($excel, $file, [
-            'callback' => function ($reader) {
+            'writerCallback' => function ($reader) {
                 $reader->setEnclosure('FOO');
             }
         ]);
@@ -769,7 +769,7 @@ public function testSaveAndCallbackWriter()
         $manager = new Manager();
 
         $manager->save($excel, $file, [
-            'callback' => function () use ($writer) {
+            'writerCallback' => function () use ($writer) {
                 return $writer;
             }
         ]);