Skip to content

Commit c15bdfa

Browse files
d-biehlbhirsz
andcommitted
fix(robocop): update robocop documentation urls
Co-authored-by: Bartlomiej Hirsz <bartlomiej.hirsz@iqvia.com>
1 parent 1ac9247 commit c15bdfa

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

packages/language_server/src/robotcode/language_server/robotframework/parts/robocop_diagnostics.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -233,25 +233,25 @@ def run_check(self, ast_model, filename, source=None): # type: ignore
233233
return result
234234

235235
def get_code_description(self, version: Version, issue: Any) -> Optional[CodeDescription]:
236+
if hasattr(issue, "rule") and hasattr(issue.rule, "docs_url"): # since robocop 6.13
237+
return CodeDescription(issue.rule.docs_url)
238+
236239
if version < (3, 0):
237240
return None
238241

239242
version_letter = "v" if version.major >= 6 else ""
240243

241-
base = f"https://robocop.readthedocs.io/en/{version_letter}{version.major}.{version.minor}.{version.patch}"
242-
243-
if version < (4, 0):
244-
return CodeDescription(href=f"{base}/rules.html#{issue.name}".lower())
245-
246-
if version < (4, 1):
247-
return CodeDescription(href=f"{base}/rules.html#{issue.name}-{issue.severity.value}{issue.rule_id}".lower())
248-
249-
if version < (4, 1, 1):
250-
return CodeDescription(
251-
href=f"{base}/rules_list.html#{issue.name}-{issue.severity.value}{issue.rule_id}".lower()
252-
)
244+
base = f"https://robocop.dev/{version_letter}{version.major}.{version.minor}.{version.patch}"
253245

254-
if version < (6, 0):
255-
return CodeDescription(href=f"{base}/rules_list.html#{issue.name}".lower())
246+
if version >= (6, 0):
247+
href = f"{base}/rules/rules_list.html#{issue.rule.rule_id}-{issue.rule.name}"
248+
elif version >= (4, 1, 1):
249+
href = f"{base}/rules_list.html#{issue.name}"
250+
elif version >= (4, 1):
251+
href = f"{base}/rules_list.html#{issue.name}-{issue.severity.value}{issue.rule_id}"
252+
elif version >= (4, 0):
253+
href = f"{base}/rules.html#{issue.name}-{issue.severity.value}{issue.rule_id}"
254+
else:
255+
href = f"{base}/rules.html#{issue.name}"
256256

257-
return CodeDescription(href=f"{base}/rules/rules_list.html#{issue.rule.rule_id}-{issue.rule.name}".lower())
257+
return CodeDescription(href=href.lower())

0 commit comments

Comments
 (0)